[PATCH] drm/xe: fix multicast support for ADL-P platforms

Matt Roper matthew.d.roper at intel.com
Thu Apr 4 15:22:47 UTC 2024


On Thu, Apr 04, 2024 at 04:18:29PM +0200, Andrzej Hajda wrote:
> ADL-P has six sublices per slice.

The code change is correct, but the title/commit message shouldn't say
"ADL-P" since this is actually a fix for all of the Xe_LP platforms
(TGL, RKL, DG1, ADL-S, and ADL-P).

So with an updated commit message/title,

        Bspec: 66696
        Reviewed-by: Matt Roper <matthew.d.roper at intel.com>


Matt

> 
> Signed-off-by: Andrzej Hajda <andrzej.hajda at intel.com>
> Fixes: bde5d76785bc ("drm/xe: Add helper macro to loop each DSS")
> ---
>  drivers/gpu/drm/xe/xe_gt_mcr.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_gt_mcr.c b/drivers/gpu/drm/xe/xe_gt_mcr.c
> index 866bbd26ba3f..577bd7043740 100644
> --- a/drivers/gpu/drm/xe/xe_gt_mcr.c
> +++ b/drivers/gpu/drm/xe/xe_gt_mcr.c
> @@ -297,7 +297,12 @@ static void init_steering_mslice(struct xe_gt *gt)
>  
>  static unsigned int dss_per_group(struct xe_gt *gt)
>  {
> -	return gt_to_xe(gt)->info.platform == XE_PVC ? 8 : 4;
> +	if (gt_to_xe(gt)->info.platform == XE_PVC)
> +		return 8;
> +	else if (GRAPHICS_VERx100(gt_to_xe(gt)) >= 1250)
> +		return 4;
> +	else
> +		return 6;
>  }
>  
>  /**
> 
> ---
> base-commit: 34820967ae7b45411f8f4f737c2d63b0c608e0d7
> change-id: 20240404-mcr_adlp-cf548bc8b633
> 
> Best regards,
> -- 
> Andrzej Hajda <andrzej.hajda at intel.com>
> 

-- 
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation


More information about the Intel-xe mailing list