✗ CI.checkpatch: warning for series starting with [v2] drm: Add drm_vblank_work_flush_all(). (rev2)

Patchwork patchwork at emeril.freedesktop.org
Fri Apr 5 15:03:17 UTC 2024


== Series Details ==

Series: series starting with [v2] drm: Add drm_vblank_work_flush_all(). (rev2)
URL   : https://patchwork.freedesktop.org/series/132027/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
10b531c2aeb176a1a539b4a77216232f97719cec
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 3a7630ceae6828e67aab07add547a33d3c6dbeb7
Author: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
Date:   Thu Apr 4 12:48:13 2024 +0200

    drm/i915: Use the same vblank worker for atomic unpin
    
    In case of legacy cursor update, the cursor VMA needs to be unpinned
    only after vblank. This exceeds the lifetime of the whole atomic commit.
    
    Any trick I attempted to keep the atomic commit alive didn't work, as
    drm_atomic_helper_setup_commit() force throttles on any old commit that
    wasn't cleaned up.
    
    The only option remaining is to remove the plane from the atomic commit,
    and use the same path as the legacy cursor update to clean the state
    after vblank.
    
    Changes since previous version:
    - Call the memset for plane state immediately when scheduling vblank,
      this prevents a use-after-free in cursor cleanup.
    
    Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
+ /mt/dim checkpatch 5714711c6612120bd9c306824ec807d322c0735b drm-intel
3b17abb3980c drm: Add drm_vblank_work_flush_all().
-:33: WARNING:WAITQUEUE_ACTIVE: waitqueue_active without comment
#33: FILE: drivers/gpu/drm/drm_vblank_work.c:249:
+			    !waitqueue_active(&vblank->work_wait_queue),

total: 0 errors, 1 warnings, 0 checks, 41 lines checked
853c9a5b399a drm/i915: Use vblank worker to unpin old legacy cursor fb safely
3a7630ceae68 drm/i915: Use the same vblank worker for atomic unpin
-:107: WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#107: FILE: drivers/gpu/drm/i915/display/intel_crtc.c:641:
+							 drm_crtc_accurate_vblank_count(&crtc->base) + 1,

-:110: WARNING:LONG_LINE_COMMENT: line length of 110 exceeds 100 columns
#110: FILE: drivers/gpu/drm/i915/display/intel_crtc.c:644:
+				/* Remove plane from atomic state, cleanup/free is done from vblank worker. */

total: 0 errors, 2 warnings, 0 checks, 98 lines checked




More information about the Intel-xe mailing list