✗ CI.checkpatch: warning for series starting with [v6,1/3] drm/xe: Store xe_he_engine in xe_hw_engine_snapshot

[Patchwork]

== Series Details ==

Series: series starting with [v6,1/3] drm/xe: Store xe_he_engine in xe_hw_engine_snapshot
URL   : https://patchwork.freedesktop.org/series/132095/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
10b531c2aeb176a1a539b4a77216232f97719cec
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 58386088cb91a4ce47f6c8549307ea0d22fc1401
Author: José Roberto de Souza <jose.souza at intel.com>
Date:   Fri Apr 5 11:23:26 2024 -0700

    drm/xe: Add INSTDONE registers to devcoredump
    
    This registers contains important information that can help with debug
    of GPU hangs.
    
    While at it also fixing the double line jump at the end of engine
    registers for CCS engines.
    
    v2:
    - print other INSTDONE registers
    
    v3:
    - add for_each_geometry/compute_dss()
    
    v4:
    - print one slice_common_instdone per glice in DG2+
    
    v5:
    - rename registers prefix from DG2 to XEHPG (Zhanjun)
    
    Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
    Cc: Matt Roper <matthew.d.roper at intel.com>
    Cc: Zhanjun Dong <zhanjun.dong at intel.com>
    Signed-off-by: José Roberto de Souza <jose.souza at intel.com>
+ /mt/dim checkpatch 11155f150a41d028c6ac7a141924fd4c8798721d drm-intel
d4547ed1589b drm/xe: Store xe_he_engine in xe_hw_engine_snapshot
361a946197fe drm/xe: Add helpers to loop over geometry and compute DSS
-:39: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#39: FILE: drivers/gpu/drm/xe/xe_gt_mcr.h:51:
+#define for_each_geometry_dss(dss, gt, group, instance) \
+		for_each_dss_steering(dss, gt, group, instance) \
+			if (xe_gt_has_geometry_dss(gt, dss))

-:39: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dss' - possible side-effects?
#39: FILE: drivers/gpu/drm/xe/xe_gt_mcr.h:51:
+#define for_each_geometry_dss(dss, gt, group, instance) \
+		for_each_dss_steering(dss, gt, group, instance) \
+			if (xe_gt_has_geometry_dss(gt, dss))

-:39: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'gt' - possible side-effects?
#39: FILE: drivers/gpu/drm/xe/xe_gt_mcr.h:51:
+#define for_each_geometry_dss(dss, gt, group, instance) \
+		for_each_dss_steering(dss, gt, group, instance) \
+			if (xe_gt_has_geometry_dss(gt, dss))

-:51: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#51: FILE: drivers/gpu/drm/xe/xe_gt_mcr.h:63:
+#define for_each_compute_dss(dss, gt, group, instance) \
+		for_each_dss_steering(dss, gt, group, instance) \
+			if (xe_gt_has_compute_dss(gt, dss))

-:51: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dss' - possible side-effects?
#51: FILE: drivers/gpu/drm/xe/xe_gt_mcr.h:63:
+#define for_each_compute_dss(dss, gt, group, instance) \
+		for_each_dss_steering(dss, gt, group, instance) \
+			if (xe_gt_has_compute_dss(gt, dss))

-:51: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'gt' - possible side-effects?
#51: FILE: drivers/gpu/drm/xe/xe_gt_mcr.h:63:
+#define for_each_compute_dss(dss, gt, group, instance) \
+		for_each_dss_steering(dss, gt, group, instance) \
+			if (xe_gt_has_compute_dss(gt, dss))

total: 2 errors, 0 warnings, 4 checks, 48 lines checked
58386088cb91 drm/xe: Add INSTDONE registers to devcoredump
-:130: WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#130: FILE: drivers/gpu/drm/xe/xe_hw_engine.c:806:
+				xe_gt_mcr_unicast_read(gt, XEHPG_SC_INSTDONE_EXTRA, group, instance);

-:132: WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#132: FILE: drivers/gpu/drm/xe/xe_hw_engine.c:808:
+				xe_gt_mcr_unicast_read(gt, XEHPG_SC_INSTDONE_EXTRA2, group, instance);

total: 0 errors, 2 warnings, 0 checks, 239 lines checked