✗ CI.checkpatch: warning for drm: debug logging improvements (rev2)
Patchwork
patchwork at emeril.freedesktop.org
Mon Apr 8 14:14:46 UTC 2024
== Series Details ==
Series: drm: debug logging improvements (rev2)
URL : https://patchwork.freedesktop.org/series/130879/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
10b531c2aeb176a1a539b4a77216232f97719cec
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit fe4e0a0f95676fff47ba34cb2312e51337bcc05f
Author: Jani Nikula <jani.nikula at intel.com>
Date: Mon Apr 8 12:24:02 2024 +0300
drm: prefer DRM_MODE_FMT/ARG over drm_mode_debug_printmodeline()
We have DRM_MODE_FMT and DRM_MODE_ARG() macros to allow unified debug
printing of modes in any printk-formatted logging. Prefer them over
drm_mode_debug_printmodeline().
This allows drm device specific logging of modes, in the right drm debug
category, and inline with the rest of the logging instead of split to
multiple lines.
Suggested-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula at intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
+ /mt/dim checkpatch 5d058f536ececea21773ccaf527e2b74e5e99d01 drm-intel
9299ce0505ec drm/probe-helper: switch to drm device based logging
980f8580d8c1 drm/modes: switch to drm device based error logging
30d6c352449b drm/sysfs: switch to drm device based logging
2a521ebcff02 drm/client: switch to drm device based logging, and more
-:328: WARNING:LONG_LINE: line length of 112 exceeds 100 columns
#328: FILE: drivers/gpu/drm/drm_client_modeset.c:875:
+ if (drm_WARN_ON_ONCE(dev, modeset->num_connectors == DRM_CLIENT_MAX_CLONED_CONNECTORS ||
-:329: WARNING:LONG_LINE: line length of 112 exceeds 100 columns
#329: FILE: drivers/gpu/drm/drm_client_modeset.c:876:
+ (dev->mode_config.num_crtc > 1 && modeset->num_connectors == 1))) {
total: 0 errors, 2 warnings, 0 checks, 298 lines checked
27ceaa597a9a drm/crtc: switch to drm device based logging
0ff12fa6095c drm/crtc-helper: switch to drm device based logging and warns
-:251: WARNING:LONG_LINE: line length of 114 exceeds 100 columns
#251: FILE: drivers/gpu/drm/drm_crtc_helper.c:785:
+ drm_dbg_kms(dev, "\t[CONNECTOR:%d:%s] set DPMS on\n", set->connectors[i]->base.id,
total: 0 errors, 1 warnings, 0 checks, 251 lines checked
fe4e0a0f9567 drm: prefer DRM_MODE_FMT/ARG over drm_mode_debug_printmodeline()
-:79: WARNING:LONG_LINE: line length of 114 exceeds 100 columns
#79: FILE: drivers/gpu/drm/drm_crtc_helper.c:769:
+ drm_dbg_kms(dev, "[CRTC:%d:%s] attempting to set mode from userspace: " DRM_MODE_FMT "\n",
-:118: WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#118: FILE: drivers/gpu/drm/drm_modes.c:1816:
+ DRM_MODE_ARG(mode), drm_get_mode_status_name(mode->status));
total: 0 errors, 2 warnings, 0 checks, 86 lines checked
More information about the Intel-xe
mailing list