[PATCH v3 03/11] drm/xe/bmg: Add BMG platform definition

[Lucas De Marchi]

On Mon, Apr 08, 2024 at 10:35:37PM +0530, Balasubramani Vivekanandan wrote:
>From: Matt Roper <matthew.d.roper at intel.com>
>
>BMG is a discrete GPU based on the Xe2 architecture.
>No device ids are bound to the BMG platform descriptor yet.
>BMG device ids will be added once we have all the basic required
>platform enabling patches landed.
>
>v2: Removed device ids, deferring it to a later patch
>
>Bspec: 68090
>Signed-off-by: Matt Roper <matthew.d.roper at intel.com>
>Signed-off-by: Balasubramani Vivekanandan <balasubramani.vivekanandan at intel.com>
>---
> drivers/gpu/drm/xe/xe_pci.c            | 6 ++++++
> drivers/gpu/drm/xe/xe_platform_types.h | 1 +
> 2 files changed, 7 insertions(+)
>
>diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
>index 2d3b18d6404e..3b30353dbc09 100644
>--- a/drivers/gpu/drm/xe/xe_pci.c
>+++ b/drivers/gpu/drm/xe/xe_pci.c
>@@ -337,6 +337,12 @@ static const struct xe_device_desc lnl_desc = {
> 	.require_force_probe = true,
> };
>
>+static const struct xe_device_desc bmg_desc __maybe_unused = {
>+	DGFX_FEATURES,
>+	PLATFORM(XE_BATTLEMAGE),
>+	.require_force_probe = true,
>+};
>+
> #undef PLATFORM
> __diag_pop();
>
>diff --git a/drivers/gpu/drm/xe/xe_platform_types.h b/drivers/gpu/drm/xe/xe_platform_types.h
>index 553f53dbd093..79b7042c4534 100644
>--- a/drivers/gpu/drm/xe/xe_platform_types.h
>+++ b/drivers/gpu/drm/xe/xe_platform_types.h
>@@ -22,6 +22,7 @@ enum xe_platform {
> 	XE_PVC,
> 	XE_METEORLAKE,
> 	XE_LUNARLAKE,
>+	XE_BATTLEMAGE,

See https://lore.kernel.org/all/jmgaruuivoineqbkx6rvu6n5qasuq4lev6vwwytyt7vwnog3q6@fl3tkitfwbfv/
I don't see a point in not declaring the IS_BATTLEMAGE()  separately
in https://patchwork.freedesktop.org/patch/586853/?series=131983&rev=2

Having the sw-only platform sketch in a single commit IMO would be
better. Anyway, this is just a nitpick if you have to respin this

Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

Lucas De Marchi


> };
>
> enum xe_subplatform {
>-- 
>2.25.1
>