[PATCH v7 3/4] drm/xe/hwmon: Update xe_hwmon_process_reg

Lucas De Marchi lucas.demarchi at intel.com
Tue Apr 9 17:52:34 UTC 2024


On Fri, Apr 05, 2024 at 06:31:26PM +0530, Karthik Poosa wrote:
>Return u64 from xe_hwmon_process_reg, instead of a void return.
>u64* input pointer not needed with this change.
>
>With this caller can directly assign return value to a variable without
>need of explicit initialization and pass by reference.
>
>v2:
> - Fix checkpatch warnings.
>
>v3:
> - Rebase
> - Removed unncessary break statements.
>
>Signed-off-by: Karthik Poosa <karthik.poosa at intel.com>
>Suggested-by: Lucas De Marchi <lucas.demarchi at intel.com>
>Cc: Badal Nilawar <badal.nilawar at intel.com>

Applied the other patches.  This one I'm putting on hold to think about.

I'm not sure the approach in that hwmon in general is good with the
xe_hwmon_get_reg() + xe_hwmon_process_reg(). It seems it's even taking
some pm refs when it doesn't need (to decide if attribute is visible).

Lucas De Marchi


More information about the Intel-xe mailing list