[PATCH v2 2/4] drm/xe: Incase of action add failure, remove sysfs only once.

Lucas De Marchi lucas.demarchi at intel.com
Tue Apr 9 19:52:28 UTC 2024


On Mon, Apr 08, 2024 at 08:19:42PM +0530, Himal Prasad Ghimiray wrote:
>The drmm_add_action_or_reset function automatically invokes the action
>(sysfs removal) in the event of a failure; therefore, there's no
>necessity to call it within the return check. Additionally, it issues a
>warning regarding the failure to add the action. Consequently, there's
>no requirement to print a nearly identical warning within the xe driver.

there's actually no need to print a warning at all? If we already add a
warning in drmm_add_action_or_reset(), that should be sufficient.


Lucas De Marchi


More information about the Intel-xe mailing list