✗ CI.checkpatch: warning for series starting with [v7,1/2] drm/xe: add a new debugfs file - mmio

Patchwork patchwork at emeril.freedesktop.org
Mon Apr 15 16:25:10 UTC 2024


== Series Details ==

Series: series starting with [v7,1/2] drm/xe: add a new debugfs file - mmio
URL   : https://patchwork.freedesktop.org/series/132409/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
04432599dcb1becb52633b02487fe3c638ba5915
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit ea37fc6438410d7d648f040c4f496432a5f93e22
Author: Koby Elbaz <kelbaz at habana.ai>
Date:   Sun Apr 14 11:11:05 2024 +0300

    drm/xe: restore xe_mmio_ioctl as the ioctl handler of the mmio debugfs file
    
    The drm mmio ioctl handler (xe_mmio_ioctl) wasn't needed anymore,
    and therefore, recently removed.
    Nevertheless, it is now restored for debugging purposes to function
    as the ioctl handler of the 'mmio' debugfs file.
    
    Notes:
    1. The non-admin user's limited mmio access (aka, whitelist),
    was removed being irrelevant anymore, now that a user using debugfs
    must anyway have root permission to use it.
    2. To support multi-tile access, the tile index is now dynamic and
    will be retrieved from the given mmio address itself.
    
    Cc: Matt Roper <matthew.d.roper at intel.com>
    Cc: Daniel Vetter <daniel at ffwll.ch>
    Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
    Cc: Ofir Bitton <obitton at habana.ai>
    Cc: José Roberto de Souza <jose.souza at intel.com>
    Cc: Michal Winiarski <michal.winiarski at intel.com>
    Signed-off-by: Koby Elbaz <kelbaz at habana.ai>
    Reviewed-by: Ofir Bitton <obitton at habana.ai>
+ /mt/dim checkpatch eb71974e8580aeae58e59b3a35e9f41d70edf968 drm-intel
b86d64e10e1d drm/xe: add a new debugfs file - mmio
ea37fc643841 drm/xe: restore xe_mmio_ioctl as the ioctl handler of the mmio debugfs file
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:71: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mmio_addr >= tile_mmio_base_addr'
#71: FILE: drivers/gpu/drm/xe/xe_debugfs.c:129:
+		if ((mmio_addr >= tile_mmio_base_addr) &&
+				(mmio_addr < (tile_mmio_base_addr + SZ_4M))) {

-:72: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#72: FILE: drivers/gpu/drm/xe/xe_debugfs.c:130:
+		if ((mmio_addr >= tile_mmio_base_addr) &&
+				(mmio_addr < (tile_mmio_base_addr + SZ_4M))) {

-:218: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#218: 
new file mode 100644

total: 0 errors, 1 warnings, 2 checks, 222 lines checked




More information about the Intel-xe mailing list