✓ CI.checkpatch: success for drm/xe/preempt_fence: enlarge the fence critical section
Patchwork
patchwork at emeril.freedesktop.org
Thu Apr 18 18:06:48 UTC 2024
== Series Details ==
Series: drm/xe/preempt_fence: enlarge the fence critical section
URL : https://patchwork.freedesktop.org/series/132610/
State : success
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
f5fb02e01091a469b6325b72a47b3a0a1e96309c
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit cdb65692165abc57b1bb222d43ddc004e24dd1e0
Author: Matthew Auld <matthew.auld at intel.com>
Date: Thu Apr 18 15:46:31 2024 +0100
drm/xe/preempt_fence: enlarge the fence critical section
It is really easy to introduce subtle deadlocks in
preempt_fence_work_func() since we operate on single global ordered-wq
for signalling our preempt fences behind the scenes, so even though we
signal a particular fence, everything in the callback should be in the
fence critical section, since blocking in the callback will prevent
other published fences from signalling. If we enlarge the fence critical
section to cover the entire callback, then lockdep should be able to
understand this better, and complain if we grab a sensitive lock like
vm->lock, which is also held when waiting on preempt fences.
Signed-off-by: Matthew Auld <matthew.auld at intel.com>
Cc: Matthew Brost <matthew.brost at intel.com>
+ /mt/dim checkpatch 9f73c1a935bbd48cb284c30ada00b34357c4ca97 drm-intel
cdb65692165a drm/xe/preempt_fence: enlarge the fence critical section
More information about the Intel-xe
mailing list