✓ CI.checkpatch: success for drm/i915: Convert intel_runtime_pm_get_noresume towards raw wakeref (rev2)
Patchwork
patchwork at emeril.freedesktop.org
Thu Apr 18 23:58:01 UTC 2024
== Series Details ==
Series: drm/i915: Convert intel_runtime_pm_get_noresume towards raw wakeref (rev2)
URL : https://patchwork.freedesktop.org/series/132624/
State : success
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
0daf0be5bb95eb0a0e42275e00a0e42d8d8fd543
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 46588c4f6c52026911c83171934e18cc7caa96ab
Author: Rodrigo Vivi <rodrigo.vivi at intel.com>
Date: Thu Apr 18 18:37:56 2024 -0400
drm/i915: Convert intel_runtime_pm_get_noresume towards raw wakeref
In the past, the noresume function was used by the GEM code to ensure
wakelocks were held and bump its usage. This is no longer the case
and this function was totally unused until it started to be used again
by display with commit 77e619a82fc3 ("drm/i915/display: convert inner
wakeref get towards get_if_in_use")
However, on the display code, most of the callers are using the
raw wakeref, rather then the wakelock version. What caused a
major regression caught by CI.
Another option to this patch is to go with the original plan and
use the get_if_in_use variant in the display code, what is enough
to fulfil our needs. Then, an extra patch to delete the unused
_noresume variant.
v2: Keep grabbing wakelock but only assert for wakeref. (Imre)
Cc: Imre Deak <imre.deak at intel.com>
Cc: Francois Dugast <francois.dugast at intel.com>
Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
Fixes: 77e619a82fc3 ("drm/i915/display: convert inner wakeref get towards get_if_in_use")
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/10875
Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
+ /mt/dim checkpatch cabe88f47c1f688f4493de88acc532bf584efe3c drm-intel
46588c4f6c52 drm/i915: Convert intel_runtime_pm_get_noresume towards raw wakeref
More information about the Intel-xe
mailing list