✓ CI.checkpatch: success for drm/xe/preempt_fence: enlarge the fence critical section (rev2)

Patchwork patchwork at emeril.freedesktop.org
Fri Apr 19 07:43:56 UTC 2024


== Series Details ==

Series: drm/xe/preempt_fence: enlarge the fence critical section (rev2)
URL   : https://patchwork.freedesktop.org/series/132610/
State : success

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
0daf0be5bb95eb0a0e42275e00a0e42d8d8fd543
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 72b1be94c37a00f738e01630c1e8c045acc774a1
Author: Matthew Auld <matthew.auld at intel.com>
Date:   Thu Apr 18 15:46:31 2024 +0100

    drm/xe/preempt_fence: enlarge the fence critical section
    
    It is really easy to introduce subtle deadlocks in
    preempt_fence_work_func() since we operate on single global ordered-wq
    for signalling our preempt fences behind the scenes, so even though we
    signal a particular fence, everything in the callback should be in the
    fence critical section, since blocking in the callback will prevent
    other published fences from signalling. If we enlarge the fence critical
    section to cover the entire callback, then lockdep should be able to
    understand this better, and complain if we grab a sensitive lock like
    vm->lock, which is also held when waiting on preempt fences.
    
    Signed-off-by: Matthew Auld <matthew.auld at intel.com>
    Cc: Matthew Brost <matthew.brost at intel.com>
    Reviewed-by: Matthew Brost <matthew.brost at intel.com>
+ /mt/dim checkpatch 1f816172a689b95011a1c1cfe952ac6ec32d3ca3 drm-intel
72b1be94c37a drm/xe/preempt_fence: enlarge the fence critical section




More information about the Intel-xe mailing list