[PATCH v3 1/2] drm/xe/vm: Use xe_vm_lock()/xe_vm_unlock() helpers

Matthew Brost matthew.brost at intel.com
Thu Apr 25 06:01:42 UTC 2024


On Wed, Apr 24, 2024 at 10:09:09AM +0530, Himal Prasad Ghimiray wrote:
> There is no change in functionality. Using the helper function
> defined within the driver.
> 
> -v2
> Use xe_vm_unlock() (Ashutosh/Matt)
> 
> -v3
> Use xe_vm_unlock() for error label too (Matt)
> 
> Reviewed-by: Badal Nilawar <badal.nilawar at intel.com>
> Cc: Matthew Brost <matthew.brost at intel.com>

Reviewed-by: Matthew Brost <matthew.brost at intel.com>

> Cc: Ashutosh Dixit <ashutosh.dixit at intel.com>
> Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray at intel.com>
> ---
>  drivers/gpu/drm/xe/xe_vm.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> index 85d6f359142d..5c9d48203d73 100644
> --- a/drivers/gpu/drm/xe/xe_vm.c
> +++ b/drivers/gpu/drm/xe/xe_vm.c
> @@ -1279,7 +1279,7 @@ struct xe_vm *xe_vm_create(struct xe_device *xe, u32 flags)
>  
>  	drm_gem_object_put(vm_resv_obj);
>  
> -	err = dma_resv_lock_interruptible(xe_vm_resv(vm), NULL);
> +	err = xe_vm_lock(vm, true);
>  	if (err)
>  		goto err_close;
>  
> @@ -1323,7 +1323,7 @@ struct xe_vm *xe_vm_create(struct xe_device *xe, u32 flags)
>  
>  		xe_pt_populate_empty(tile, vm, vm->pt_root[id]);
>  	}
> -	dma_resv_unlock(xe_vm_resv(vm));
> +	xe_vm_unlock(vm);
>  
>  	/* Kernel migration VM shouldn't have a circular loop.. */
>  	if (!(flags & XE_VM_FLAG_MIGRATION)) {
> @@ -1365,7 +1365,7 @@ struct xe_vm *xe_vm_create(struct xe_device *xe, u32 flags)
>  	return vm;
>  
>  err_unlock_close:
> -	dma_resv_unlock(xe_vm_resv(vm));
> +	xe_vm_unlock(vm);
>  err_close:
>  	xe_vm_close_and_put(vm);
>  	return ERR_PTR(err);
> -- 
> 2.25.1
> 


More information about the Intel-xe mailing list