[PATCH v2 1/5] drm/xe: s/ENGINE_STATE_ENABLED/EXEC_QUEUE_STATE_ENABLED

[Ghimiray, Himal Prasad]

> -----Original Message-----
> From: Intel-xe <intel-xe-bounces at lists.freedesktop.org> On Behalf Of
> Matthew Brost
> Sent: 25 April 2024 11:25
> To: intel-xe at lists.freedesktop.org
> Cc: Brost, Matthew <matthew.brost at intel.com>
> Subject: [PATCH v2 1/5] drm/xe:
> s/ENGINE_STATE_ENABLED/EXEC_QUEUE_STATE_ENABLED
> 
> Exec queue has replaced engine nomenclature.
> 
> Signed-off-by: Matthew Brost <matthew.brost at intel.com>
> ---
>  drivers/gpu/drm/xe/xe_guc_submit.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c
> b/drivers/gpu/drm/xe/xe_guc_submit.c
> index 4e78610d1591..689093259302 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.c
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.c
> @@ -52,7 +52,7 @@ exec_queue_to_guc(struct xe_exec_queue *q)
>   * engine done being processed).
>   */
>  #define EXEC_QUEUE_STATE_REGISTERED		(1 << 0)
> -#define ENGINE_STATE_ENABLED		(1 << 1)
> +#define EXEC_QUEUE_STATE_ENABLED		(1 << 1)
>  #define EXEC_QUEUE_STATE_PENDING_ENABLE	(1 << 2)
>  #define EXEC_QUEUE_STATE_PENDING_DISABLE	(1 << 3)
>  #define EXEC_QUEUE_STATE_DESTROYED		(1 << 4)
> @@ -77,17 +77,17 @@ static void clear_exec_queue_registered(struct
> xe_exec_queue *q)
> 
>  static bool exec_queue_enabled(struct xe_exec_queue *q)  {
> -	return atomic_read(&q->guc->state) & ENGINE_STATE_ENABLED;
> +	return atomic_read(&q->guc->state) &
> EXEC_QUEUE_STATE_ENABLED;
>  }
> 
>  static void set_exec_queue_enabled(struct xe_exec_queue *q)  {
> -	atomic_or(ENGINE_STATE_ENABLED, &q->guc->state);
> +	atomic_or(EXEC_QUEUE_STATE_ENABLED, &q->guc->state);
>  }
> 
>  static void clear_exec_queue_enabled(struct xe_exec_queue *q)  {
> -	atomic_and(~ENGINE_STATE_ENABLED, &q->guc->state);
> +	atomic_and(~EXEC_QUEUE_STATE_ENABLED, &q->guc->state);
>  }


LGTM
Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray at intel.com>

> 
>  static bool exec_queue_pending_enable(struct xe_exec_queue *q)
> --
> 2.34.1