[PATCH v2 3/5] drm/xe: s/ENGINE_STATE_KILLED/EXEC_QUEUE_STATE_KILLED

Ghimiray, Himal Prasad himal.prasad.ghimiray at intel.com
Thu Apr 25 07:01:13 UTC 2024



> -----Original Message-----
> From: Intel-xe <intel-xe-bounces at lists.freedesktop.org> On Behalf Of
> Matthew Brost
> Sent: 25 April 2024 11:25
> To: intel-xe at lists.freedesktop.org
> Cc: Brost, Matthew <matthew.brost at intel.com>
> Subject: [PATCH v2 3/5] drm/xe:
> s/ENGINE_STATE_KILLED/EXEC_QUEUE_STATE_KILLED
> 
> Exec queue has replaced engine nomenclature.
> 
> Signed-off-by: Matthew Brost <matthew.brost at intel.com>
> ---
>  drivers/gpu/drm/xe/xe_guc_submit.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c
> b/drivers/gpu/drm/xe/xe_guc_submit.c
> index b26f374ca20b..19f92a107342 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.c
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.c
> @@ -58,7 +58,7 @@ exec_queue_to_guc(struct xe_exec_queue *q)
>  #define EXEC_QUEUE_STATE_DESTROYED		(1 << 4)
>  #define EXEC_QUEUE_STATE_SUSPENDED		(1 << 5)
>  #define EXEC_QUEUE_STATE_RESET		(1 << 6)
> -#define ENGINE_STATE_KILLED		(1 << 7)
> +#define EXEC_QUEUE_STATE_KILLED			(1 << 7)
> 
>  static bool exec_queue_registered(struct xe_exec_queue *q)  { @@ -167,12
> +167,12 @@ static void set_exec_queue_reset(struct xe_exec_queue *q)
> 
>  static bool exec_queue_killed(struct xe_exec_queue *q)  {
> -	return atomic_read(&q->guc->state) & ENGINE_STATE_KILLED;
> +	return atomic_read(&q->guc->state) & EXEC_QUEUE_STATE_KILLED;
>  }
> 
>  static void set_exec_queue_killed(struct xe_exec_queue *q)  {
> -	atomic_or(ENGINE_STATE_KILLED, &q->guc->state);
> +	atomic_or(EXEC_QUEUE_STATE_KILLED, &q->guc->state);

LGTM
Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray at intel.com>

>  }
> 
>  static bool exec_queue_killed_or_banned(struct xe_exec_queue *q)
> --
> 2.34.1



More information about the Intel-xe mailing list