✗ CI.checkpatch: warning for drm/xe/display: Fix ADL-N detection

Patchwork patchwork at emeril.freedesktop.org
Thu Apr 25 18:21:26 UTC 2024


== Series Details ==

Series: drm/xe/display: Fix ADL-N detection
URL   : https://patchwork.freedesktop.org/series/132919/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
0daf0be5bb95eb0a0e42275e00a0e42d8d8fd543
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit d7ef9999cda999571461cd1303aeb2d6a045b13f
Author: Lucas De Marchi <lucas.demarchi at intel.com>
Date:   Thu Apr 25 11:16:09 2024 -0700

    drm/xe/display: Fix ADL-N detection
    
    Contrary to i915, in xe ADL-N is kept as a different platform, not a
    subplatform of ADL-P. Since the display side doesn't need to
    differentiate between P and N, i.e. IS_ALDERLAKE_P_N() is never called,
    just fixup the compat header to check for both P and N.
    
    Moving ADL-N to be a subplatform would be more complex as the firmware
    loading in xe only handles platforms, not subplatforms, as going forward
    the direction is to check on IP version rather than
    platforms/subplatforms.
    
    Fix warning when initializing display:
    
            xe 0000:00:02.0: [drm:intel_pch_type [xe]] Found Alder Lake PCH
            ------------[ cut here ]------------
            xe 0000:00:02.0: drm_WARN_ON(!((dev_priv)->info.platform == XE_ALDERLAKE_S) && !((dev_priv)->info.platform == XE_ALDERLAKE_P))
    
    And wrong paths being taken on the display side.
    
    Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
+ /mt/dim checkpatch 92b848b529903fb99d21168491692474aae4872c drm-intel
d7ef9999cda9 drm/xe/display: Fix ADL-N detection
-:20: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#20: 
	xe 0000:00:02.0: drm_WARN_ON(!((dev_priv)->info.platform == XE_ALDERLAKE_S) && !((dev_priv)->info.platform == XE_ALDERLAKE_P))

-:35: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv' - possible side-effects?
#35: FILE: drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h:81:
+#define IS_ALDERLAKE_P(dev_priv) (IS_PLATFORM(dev_priv, XE_ALDERLAKE_P) || \
+				  IS_PLATFORM(dev_priv, XE_ALDERLAKE_N))

total: 0 errors, 1 warnings, 1 checks, 9 lines checked




More information about the Intel-xe mailing list