✓ CI.checkpatch: success for drm/xe/xe_ggtt: No need to use xe_pm_runtime_get_noresume

Patchwork patchwork at emeril.freedesktop.org
Mon Apr 29 16:34:49 UTC 2024


== Series Details ==

Series: drm/xe/xe_ggtt: No need to use xe_pm_runtime_get_noresume
URL   : https://patchwork.freedesktop.org/series/133031/
State : success

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
0daf0be5bb95eb0a0e42275e00a0e42d8d8fd543
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit c41d51bb1c5a41573232326508bb534351601e43
Author: Ashutosh Dixit <ashutosh.dixit at intel.com>
Date:   Mon Apr 29 09:29:15 2024 -0700

    drm/xe/xe_ggtt: No need to use xe_pm_runtime_get_noresume
    
    Switching from xe_device_mem_access_get/put to xe_pm_runtime_get/put
    results in the following WARNING in xe_oa:
    
    [11614.356168] xe 0000:00:02.0: Missing outer runtime PM protection
    [11614.356187] WARNING: CPU: 1 PID: 13075 at drivers/gpu/drm/xe/xe_pm.c:549 xe_pm_runtime_get_noresume+0x60/0x80 [xe]
    ...
    [11614.356377] Call Trace:
    [11614.356379]  <TASK>
    [11614.356381]  ? __warn+0x7e/0x180
    [11614.356387]  ? xe_pm_runtime_get_noresume+0x60/0x80 [xe]
    [11614.356507]  xe_ggtt_remove_node+0x22/0x80 [xe]
    [11614.356546]  xe_ttm_bo_destroy+0xea/0xf0 [xe]
    [11614.356579]  xe_oa_stream_destroy+0xf7/0x120 [xe]
    [11614.356627]  xe_oa_release+0x35/0xc0 [xe]
    [11614.356673]  __fput+0xa1/0x2d0
    [11614.356679]  __x64_sys_close+0x37/0x80
    [11614.356697]  do_syscall_64+0x6d/0x140
    [11614.356700]  entry_SYSCALL_64_after_hwframe+0x71/0x79
    [11614.356702] RIP: 0033:0x7f2b37314f67
    
    There seems to be no reason to use xe_pm_runtime_get_noresume in xe_ggtt
    functions. Just use xe_pm_runtime_get.
    
    Signed-off-by: Ashutosh Dixit <ashutosh.dixit at intel.com>
+ /mt/dim checkpatch acf512bb5ff4d2e8ed5ef67444b6c1f92a222d77 drm-intel
c41d51bb1c5a drm/xe/xe_ggtt: No need to use xe_pm_runtime_get_noresume




More information about the Intel-xe mailing list