✗ CI.checkpatch: warning for Faster devcoredump and fixes (rev2)
Patchwork
patchwork at emeril.freedesktop.org
Thu Aug 1 15:46:06 UTC 2024
== Series Details ==
Series: Faster devcoredump and fixes (rev2)
URL : https://patchwork.freedesktop.org/series/136770/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
7b537a014c4c1a32250e342541870b03977fa7a4
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit dd2562e06301bda4f9977fb8f094b51c771e2698
Author: Matthew Brost <matthew.brost at intel.com>
Date: Thu Aug 1 08:41:18 2024 -0700
drm/xe: Faster devcoredump
The current algorithm to read out devcoredump is O(N*N) where N is the
size of coredump due to usage of the drm_coredump_printer in
xe_devcoredump_read. Switch to a O(N) algorithm which prints the
devcoredump into a readable format in snapshot work and update
xe_devcoredump_read to memcpy from the readable format directly.
v2:
- Fix double free on devcoredump removal (Testing)
- Set read_data_size after snap work flush
- Adjust remaining in iterator upon realloc (Testing)
- Set read_data upon realloc (Testing)
v3:
- Kernel doc
v4:
- Two pass algorithm to determine size (Maarten)
v5:
- Use scope for reading variables (Johnathan)
Reported-by: Paulo Zanoni <paulo.r.zanoni at intel.com>
Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2408
Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
Signed-off-by: Matthew Brost <matthew.brost at intel.com>
Reviewed-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
+ /mt/dim checkpatch abbcf7af3bd79f8729a6dba72674a81730f97f8a drm-intel
8918ad47a480 drm/xe: Take ref to VM in delayed snapshot
-:16: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 47058633d9c5 ("drm/xe: Move lrc snapshot capturing to xe_lrc.c")'
#16:
47058633d9c5 ("drm/xe: Move lrc snapshot capturing to xe_lrc.c")
total: 1 errors, 0 warnings, 0 checks, 46 lines checked
070e18dcc916 drm/printer: Allow NULL data in devcoredump printer
-:34: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#34: FILE: drivers/gpu/drm/drm_print.c:105:
+ memcpy(iterator->data,
+ str + (iterator->start - iterator->offset), copy);
-:55: CHECK:SPACING: No space is necessary after a cast
#55: FILE: drivers/gpu/drm/drm_print.c:146:
+ snprintf(((char *) iterator->data) + pos,
-:56: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#56: FILE: drivers/gpu/drm/drm_print.c:147:
+ snprintf(((char *) iterator->data) + pos,
+ iterator->remain, "%pV", vaf);
total: 0 errors, 0 warnings, 3 checks, 97 lines checked
dd2562e06301 drm/xe: Faster devcoredump
More information about the Intel-xe
mailing list