✗ CI.checkpatch: warning for Release GuC v70.29.2 as minimum for Xe (support LNL, BMG)

Patchwork patchwork at emeril.freedesktop.org
Thu Aug 1 23:26:36 UTC 2024


== Series Details ==

Series: Release GuC v70.29.2 as minimum for Xe (support LNL, BMG)
URL   : https://patchwork.freedesktop.org/series/136818/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
7b537a014c4c1a32250e342541870b03977fa7a4
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 3cb84acea6e3950b7a0720a78521c4d2018a872a
Author: Julia Filipchuk <julia.filipchuk at intel.com>
Date:   Thu Aug 1 15:42:40 2024 -0700

    drm/xe/guc: Pick for-ci GuC v70.29.2 for PVC
    
    UAPI version 1.13.4
    
    Restore ci config for pre-release PVC.
    
    Signed-off-by: Julia Filipchuk <julia.filipchuk at intel.com>
+ /mt/dim checkpatch d1ec20e149fc0bd4d15cbf34573b84d4fa47e3a5 drm-intel
6eed5eaa73a8 drm/xe/guc: Drop use of pre-release GuC definitions for LNL and BMG
-:12: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#12: 
the definitions ("drm/xe/guc: Pre-release GuC firmware v70.24.0 for LNL/BMG/PVC"). We want to keep the PVC definition from that patch.

-:29: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 1 errors, 1 warnings, 0 checks, 11 lines checked
5a7c09542f8c drm/xe/guc: Release GuC v70.29.2 for Xe as minimum required version
-:10: WARNING:TYPO_SPELLING: 'suported' may be misspelled - perhaps 'supported'?
#10: 
v70.29.2 as minimum suported.
                    ^^^^^^^^

-:98: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ver' - possible side-effects?
#98: FILE: drivers/gpu/drm/xe/xe_uc_fw.h:19:
+#define MAKE_VER_STRUCT(ver) MAKE_VER((ver).major, (ver).minor, (ver).patch)

total: 0 errors, 1 warnings, 1 checks, 70 lines checked
cb33b9978f2c drm/xe/guc: Release GuC v70.29.2 for BMG
3cb84acea6e3 drm/xe/guc: Pick for-ci GuC v70.29.2 for PVC
-:20: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#20: FILE: drivers/gpu/drm/xe/xe_uc_fw.c:112:
+	fw_def(PVC,		mmp_ver(intel-ci/xe, guc, pvc,	70, 29, 2))	\
 	           		             ^

-:20: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#20: FILE: drivers/gpu/drm/xe/xe_uc_fw.c:112:
+	fw_def(PVC,		mmp_ver(intel-ci/xe, guc, pvc,	70, 29, 2))	\
 	           		                ^

total: 0 errors, 0 warnings, 2 checks, 7 lines checked




More information about the Intel-xe mailing list