✗ CI.checkpatch: warning for drm/xe/guc: Enable w/a 14022293748 and 22019794406 (rev4)

[Patchwork]

== Series Details ==

Series: drm/xe/guc: Enable w/a 14022293748 and 22019794406 (rev4)
URL   : https://patchwork.freedesktop.org/series/136307/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
7b537a014c4c1a32250e342541870b03977fa7a4
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 13bcc37564a29a2ad74cbb819771780bc250dcbc
Author: Julia Filipchuk <julia.filipchuk at intel.com>
Date:   Thu Aug 1 17:40:17 2024 -0700

    drm/xe/guc: Enable w/a 14022293748 and 22019794406
    
    Enable workarounds for HW bug where render engine reset fails. Check
    firmware version supports the workarounds.
    
    v2: Enable KLV correctly for either workaround (Lucas)
    v4: Add check for minimum supported GuC firmware version. Enable w/a for
    hw version 20.01 too. (Daniele)
    
    Signed-off-by: Julia Filipchuk <julia.filipchuk at intel.com>
+ /mt/dim checkpatch d1ec20e149fc0bd4d15cbf34573b84d4fa47e3a5 drm-intel
282a16d6c38a NOT_UPSTREAM/CIdrm/xe/guc: Release GuC v70.29.2
-:57: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#57: FILE: drivers/gpu/drm/xe/xe_uc_fw.c:112:
+	fw_def(PVC,		mmp_ver(intel-ci/xe,	guc,	pvc,	70, 29, 2))	\
 	           		             ^

-:57: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#57: FILE: drivers/gpu/drm/xe/xe_uc_fw.c:112:
+	fw_def(PVC,		mmp_ver(intel-ci/xe,	guc,	pvc,	70, 29, 2))	\
 	           		                ^

-:99: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ver' - possible side-effects?
#99: FILE: drivers/gpu/drm/xe/xe_uc_fw.h:19:
+#define MAKE_VER_STRUCT(ver) MAKE_VER((ver).major, (ver).minor, (ver).patch)

total: 0 errors, 0 warnings, 3 checks, 74 lines checked
13bcc37564a2 drm/xe/guc: Enable w/a 14022293748 and 22019794406
-:59: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#59: FILE: drivers/gpu/drm/xe/xe_guc_ads.c:377:
+	if (fw_ver >= MAKE_VER(70, 29, 0) &&
+		(XE_WA(gt, 14022293748) || XE_WA(gt, 22019794406)))

total: 0 errors, 0 warnings, 1 checks, 50 lines checked