[PATCH 2/2] drm/xe: Add kernel doc for xe_hw_engine_lookup

Cavitt, Jonathan jonathan.cavitt at intel.com
Tue Aug 6 19:23:10 UTC 2024


-----Original Message-----
From: Intel-xe <intel-xe-bounces at lists.freedesktop.org> On Behalf Of Mika Kuoppala
Sent: Tuesday, August 6, 2024 8:30 AM
To: intel-xe at lists.freedesktop.org
Cc: Mika Kuoppala <mika.kuoppala at linux.intel.com>; Grzegorzek, Dominik <dominik.grzegorzek at intel.com>; Brost, Matthew <matthew.brost at intel.com>; De Marchi, Lucas <lucas.demarchi at intel.com>; Thomas Hellström <thomas.hellstrom at linux.intel.com>
Subject: [PATCH 2/2] drm/xe: Add kernel doc for xe_hw_engine_lookup
> 
> kerneldoc was missing from earlier commit where
> we exported xe_hw_engine_lookup. Add it.
> 
> Fixes: 6f20fc09936e ("drm/xe: Move and export xe_hw_engine lookup.")
> Cc: Dominik Grzegorzek <dominik.grzegorzek at intel.com>
> Cc: Mika Kuoppala <mika.kuoppala at linux.intel.com>
> Cc: Matthew Brost <matthew.brost at intel.com>
> Cc: Lucas De Marchi <lucas.demarchi at intel.com>
> Cc: "Thomas Hellström" <thomas.hellstrom at linux.intel.com>
> Cc: intel-xe at lists.freedesktop.org
> Signed-off-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>

LGTM.
Reviewed-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
-Jonathan Cavitt

> ---
>  drivers/gpu/drm/xe/xe_hw_engine.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_hw_engine.c b/drivers/gpu/drm/xe/xe_hw_engine.c
> index c7c44de7c30f..68180f1ff8a9 100644
> --- a/drivers/gpu/drm/xe/xe_hw_engine.c
> +++ b/drivers/gpu/drm/xe/xe_hw_engine.c
> @@ -1173,6 +1173,16 @@ static const enum xe_engine_class user_to_xe_engine_class[] = {
>  	[DRM_XE_ENGINE_CLASS_COMPUTE] = XE_ENGINE_CLASS_COMPUTE,
>  };
>  
> +/**
> + * xe_hw_engine_lookup() - Lookup hardware engine for class:instance
> + * @xe: xe device
> + * @eci: engine class and instance
> + *
> + * This function will find a hardware engine for given engine
> + * class and instance.
> + *
> + * Return: If found xe_hw_engine pointer, NULL otherwise.
> + */
>  struct xe_hw_engine *
>  xe_hw_engine_lookup(struct xe_device *xe,
>  		    struct drm_xe_engine_class_instance eci)
> -- 
> 2.34.1
> 
> 


More information about the Intel-xe mailing list