✗ CI.checkpatch: warning for drm/xe: Rename enable_display module param

Patchwork patchwork at emeril.freedesktop.org
Thu Aug 8 20:16:26 UTC 2024


== Series Details ==

Series: drm/xe: Rename enable_display module param
URL   : https://patchwork.freedesktop.org/series/137060/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
be41dd201d01bbf73d9e4ab77e74ab47923582e5
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 9e58e901435336257e1cd2778d6f3a81e49dc2e8
Author: Lucas De Marchi <lucas.demarchi at intel.com>
Date:   Thu Aug 8 10:49:42 2024 -0700

    drm/xe: Rename enable_display module param
    
    The different approach used by xe regarding the initialization of
    display HW has been proved a great additional for early driver bring up:
    core xe can be tested without having all the bits sorted out on the
    display side.
    
    On the other hand, the approach exposed by i915-display is to *actively*
    disable the display by programming it if needed, i.e. if it was left
    enabled by firmware. It also has its use to make sure the HW is actually
    disabled and not wasting power.
    
    However having both the way it is in xe doesn't expose a good interface
    wrt module params. From modinfo:
    
            disable_display:Disable display (default: false) (bool)
            enable_display:Enable display (bool)
    
    Rename enable_display do probe_display to try to convey the message that
    the HW is being touched and improve the module param description. To
    avoid confusion, the enable_display is renamed everywhere, not only in
    the module param. New description for the parameters:
    
            disable_display:Disable display (default: false) (bool)
            probe_display:Probe display HW, otherwise it's left untouched (default: true) (bool)
    
    Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
+ /mt/dim checkpatch 6eced4bb82542c5f00a48e4d7b66a10905736961 drm-intel
9e58e9014353 drm/xe: Rename enable_display module param
-:28: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#28: 
	probe_display:Probe display HW, otherwise it's left untouched (default: true) (bool)

total: 0 errors, 1 warnings, 0 checks, 251 lines checked




More information about the Intel-xe mailing list