[PATCH 4/5] drm/xe: Only enable scheduling upon resume if needed

[Cavitt, Jonathan]

-----Original Message-----
From: Intel-xe <intel-xe-bounces at lists.freedesktop.org> On Behalf Of Matthew Brost
Sent: Friday, August 9, 2024 12:19 PM
To: intel-xe at lists.freedesktop.org
Cc: Dugast, Francois <francois.dugast at intel.com>
Subject: [PATCH 4/5] drm/xe: Only enable scheduling upon resume if needed
> 
> No need to enable scheduling in already enabled.
> 
> Signed-off-by: Matthew Brost <matthew.brost at intel.com>

Makes sense to me.
Reviewed-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
-Jonathan Cavitt

> ---
>  drivers/gpu/drm/xe/xe_guc_submit.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
> index 460808507947..a9af33ff8aa7 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.c
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.c
> @@ -1374,9 +1374,11 @@ static void __guc_exec_queue_process_msg_resume(struct xe_sched_msg *msg)
>  	struct xe_exec_queue *q = msg->private_data;
>  
>  	if (guc_exec_queue_allowed_to_change_state(q)) {
> -		q->guc->resume_time = RESUME_PENDING;
>  		clear_exec_queue_suspended(q);
> -		enable_scheduling(q);
> +		if (!exec_queue_enabled(q)) {
> +			q->guc->resume_time = RESUME_PENDING;
> +			enable_scheduling(q);
> +		}
>  	} else {
>  		clear_exec_queue_suspended(q);
>  	}
> -- 
> 2.34.1
> 
>