[PATCH 0/3] uC-related drmm vs devm fixes
Matthew Brost
matthew.brost at intel.com
Fri Aug 9 23:46:02 UTC 2024
On Fri, Aug 09, 2024 at 04:12:34PM -0700, Daniele Ceraolo Spurio wrote:
> If HW access is required for cleaning up a resource, we need to use devm
> callbacks instead of drmm ones, otherwise the HW might already be gone
> by the time the cleanup function is called.
>
> The first patch in the series fixes the managed_bo callback, which is
> not uC-specific but it is used to clean up the uC objects. The second
> and third patch fix cleanup of BOs and exec_queues in uC code.
>
I can confirm this is fixing the issue mentioned in the cover letter [1]
here.
Matt
[1] https://patchwork.freedesktop.org/series/137111/
> Cc: Lucas De Marchi <lucas.demarchi at intel.com>
> Cc: Matthew Auld <matthew.auld at intel.com>
> Cc: John Harrison <John.C.Harrison at Intel.com>
> Cc: Alan Previn <alan.previn.teres.alexis at intel.com>
>
> Daniele Ceraolo Spurio (3):
> drm/xe: use devm instead of drmm for managed bo
> drm/xe/uc: Use managed bo for HuC and GSC objects
> drm/xe/uc: Use devm to register cleanup that includes exec_queues
>
> drivers/gpu/drm/xe/xe_bo.c | 6 ++---
> drivers/gpu/drm/xe/xe_gsc.c | 16 +++++--------
> drivers/gpu/drm/xe/xe_gsc_proxy.c | 36 +++++-------------------------
> drivers/gpu/drm/xe/xe_guc_submit.c | 4 ++--
> drivers/gpu/drm/xe/xe_huc.c | 19 +++++-----------
> 5 files changed, 21 insertions(+), 60 deletions(-)
>
> --
> 2.43.0
>
More information about the Intel-xe
mailing list