✗ CI.checkpatch: warning for Fix error paths in driver load

[Patchwork]

== Series Details ==

Series: Fix error paths in driver load
URL   : https://patchwork.freedesktop.org/series/137114/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
dc547930fbb1350eaf6bde84653b9ac973a411db
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit e4276e3678496a951e5af3ab44f52b0851521335
Author: Matthew Brost <matthew.brost at intel.com>
Date:   Fri Aug 9 18:55:44 2024 -0700

    drm/xe: Update xe_sa to use xe_managed_bo_create_pin_map
    
    Preferred way to create kernel BOs is xe_managed_bo_create_pin_map, use
    it.
    
    Signed-off-by: Matthew Brost <matthew.brost at intel.com>
+ /mt/dim checkpatch 99ad64bdf35cabb4af86749665508067895eb1d6 drm-intel
d3ddb2e2ad0c drm/xe: use devm instead of drmm for managed bo
40c6bc8b053c drm/xe/uc: Use managed bo for HuC and GSC objects
0467d7d6e063 drm/xe/uc: Use devm to register cleanup that includes exec_queues
2b4b8233a316 drm/xe: Fix tile fini sequence
3bd3c9f644d5 drm/xe: Add driver load error injection
-:56: ERROR:CODE_INDENT: code indent should use tabs where possible
#56: FILE: drivers/gpu/drm/xe/xe_device.c:1015:
+        if (xe->inject_driver_load_error >= xe_modparam.inject_driver_load_error)$

-:56: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#56: FILE: drivers/gpu/drm/xe/xe_device.c:1015:
+        if (xe->inject_driver_load_error >= xe_modparam.inject_driver_load_error)$

-:57: ERROR:CODE_INDENT: code indent should use tabs where possible
#57: FILE: drivers/gpu/drm/xe/xe_device.c:1016:
+                return 0;$

-:57: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#57: FILE: drivers/gpu/drm/xe/xe_device.c:1016:
+                return 0;$

-:59: ERROR:CODE_INDENT: code indent should use tabs where possible
#59: FILE: drivers/gpu/drm/xe/xe_device.c:1018:
+        if (++xe->inject_driver_load_error < xe_modparam.inject_driver_load_error)$

-:59: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#59: FILE: drivers/gpu/drm/xe/xe_device.c:1018:
+        if (++xe->inject_driver_load_error < xe_modparam.inject_driver_load_error)$

-:60: ERROR:CODE_INDENT: code indent should use tabs where possible
#60: FILE: drivers/gpu/drm/xe/xe_device.c:1019:
+                return 0;$

-:60: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#60: FILE: drivers/gpu/drm/xe/xe_device.c:1019:
+                return 0;$

-:62: ERROR:CODE_INDENT: code indent should use tabs where possible
#62: FILE: drivers/gpu/drm/xe/xe_device.c:1021:
+        drm_info(&xe->drm, "Injecting failure %d at checkpoint %u [%s:%d]\n",$

-:62: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#62: FILE: drivers/gpu/drm/xe/xe_device.c:1021:
+        drm_info(&xe->drm, "Injecting failure %d at checkpoint %u [%s:%d]\n",$

-:63: ERROR:CODE_INDENT: code indent should use tabs where possible
#63: FILE: drivers/gpu/drm/xe/xe_device.c:1022:
+                 err, xe->inject_driver_load_error, func, line);$

-:63: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#63: FILE: drivers/gpu/drm/xe/xe_device.c:1022:
+                 err, xe->inject_driver_load_error, func, line);$

-:65: ERROR:CODE_INDENT: code indent should use tabs where possible
#65: FILE: drivers/gpu/drm/xe/xe_device.c:1024:
+        xe_modparam.inject_driver_load_error = 0;$

-:65: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#65: FILE: drivers/gpu/drm/xe/xe_device.c:1024:
+        xe_modparam.inject_driver_load_error = 0;$

-:66: ERROR:CODE_INDENT: code indent should use tabs where possible
#66: FILE: drivers/gpu/drm/xe/xe_device.c:1025:
+        return err;$

-:66: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#66: FILE: drivers/gpu/drm/xe/xe_device.c:1025:
+        return err;$

-:68: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#68: FILE: drivers/gpu/drm/xe/xe_device.c:1027:
+
+}

-:258: WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#258: FILE: drivers/gpu/drm/xe/xe_module.c:57:
+module_param_named_unsafe(inject_driver_load_error, xe_modparam.inject_driver_load_error, int, 0600);

total: 8 errors, 9 warnings, 1 checks, 314 lines checked
80825dbef175 drm/xe: Move ggtt_fini to devm managed
574908a5a73f drm/xe: Set firmware state to loadable before registering guc_fini_hw
97d37d80565f drm/xe: Drop warn on xe_guc_pc_gucrc_disable in guc pc fini
99df6493572d drm/xe: Move hw_engine_fini to devm managed
ca5c6e4675e6 drm/xe: Move HuC init before GuC init
e4276e367849 drm/xe: Update xe_sa to use xe_managed_bo_create_pin_map