[PATCH] drm/xe/xe2hpg: Add Wa_14021821874

[Upadhyay, Tejas]

> -----Original Message-----
> From: Ghimiray, Himal Prasad <himal.prasad.ghimiray at intel.com>
> Sent: Monday, August 12, 2024 1:18 PM
> To: Upadhyay, Tejas <tejas.upadhyay at intel.com>; intel-
> xe at lists.freedesktop.org
> Cc: Roper, Matthew D <matthew.d.roper at intel.com>
> Subject: Re: [PATCH] drm/xe/xe2hpg: Add Wa_14021821874
> 
> 
> 
> On 12-08-2024 12:32, Tejas Upadhyay wrote:
> > Wa_14021821874 applies to xe2_hpg
> >
> > Cc: Matt Roper <matthew.d.roper at intel.com>
> > Signed-off-by: Tejas Upadhyay <tejas.upadhyay at intel.com>
> > ---
> >   drivers/gpu/drm/xe/regs/xe_gt_regs.h | 1 +
> >   drivers/gpu/drm/xe/xe_wa.c           | 4 ++++
> >   2 files changed, 5 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/xe/regs/xe_gt_regs.h
> > b/drivers/gpu/drm/xe/regs/xe_gt_regs.h
> > index 2c8c4d4218db..9054253f6aaa 100644
> > --- a/drivers/gpu/drm/xe/regs/xe_gt_regs.h
> > +++ b/drivers/gpu/drm/xe/regs/xe_gt_regs.h
> > @@ -451,6 +451,7 @@
> >   #define   DIS_FIX_EOT1_FLUSH			REG_BIT(9)
> >
> >   #define TDL_TSL_CHICKEN				XE_REG_MCR(0xe4c4,
> XE_REG_OPTION_MASKED)
> > +#define	  STK_ID_RESTRICT			REG_BIT(12)
> 
> Nit: space instead of tab ?

Thanks for comment. Its not tab, spaces only. Also strict checkpatch is clean. Locally it looks ok, don’t know why it looks like tab here on mailing list.

Thanks,
Tejas
> 
> Patch LGTM.
> Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray at intel.com>
> 
> 
> >   #define   SLM_WMTP_RESTORE			REG_BIT(11)
> >
> >   #define ROW_CHICKEN				XE_REG_MCR(0xe4f0,
> XE_REG_OPTION_MASKED)
> > diff --git a/drivers/gpu/drm/xe/xe_wa.c b/drivers/gpu/drm/xe/xe_wa.c
> > index 564e32e44e3b..28b7f95b6c2f 100644
> > --- a/drivers/gpu/drm/xe/xe_wa.c
> > +++ b/drivers/gpu/drm/xe/xe_wa.c
> > @@ -542,6 +542,10 @@ static const struct xe_rtp_entry_sr engine_was[] = {
> >   	  XE_RTP_RULES(GRAPHICS_VERSION(2001),
> ENGINE_CLASS(RENDER)),
> >   	  XE_RTP_ACTIONS(SET(HALF_SLICE_CHICKEN7,
> CLEAR_OPTIMIZATION_DISABLE))
> >   	},
> > +	{ XE_RTP_NAME("14021821874"),
> > +	  XE_RTP_RULES(GRAPHICS_VERSION(2001),
> FUNC(xe_rtp_match_first_render_or_compute)),
> > +	  XE_RTP_ACTIONS(SET(TDL_TSL_CHICKEN, STK_ID_RESTRICT))
> > +	},
> >
> >   	/* Xe2_LPM */
> >