✗ CI.checkpatch: warning for drm/xe: Rename enable_display module param (rev3)
Patchwork
patchwork at emeril.freedesktop.org
Tue Aug 13 19:22:59 UTC 2024
== Series Details ==
Series: drm/xe: Rename enable_display module param (rev3)
URL : https://patchwork.freedesktop.org/series/137060/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
9fe5037901cabbcdf27a6fe0dfb047ca1474d363
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 120d782a897bf40e4e99f5c1abbaeac30b25c90c
Author: Lucas De Marchi <lucas.demarchi at intel.com>
Date: Tue Aug 13 12:17:09 2024 -0700
drm/xe: Rename enable_display module param
The different approach used by xe regarding the initialization of
display HW has been proved a great addition for early driver bring up:
core xe can be tested without having all the bits sorted out on the
display side.
On the other hand, the approach exposed by i915-display is to *actively*
disable the display by programming it if needed, i.e. if it was left
enabled by firmware. It also has its use to make sure the HW is actually
disabled and not wasting power.
However having both the way it is in xe doesn't expose a good interface
wrt module params. From modinfo:
disable_display:Disable display (default: false) (bool)
enable_display:Enable display (bool)
Rename enable_display to probe_display to try to convey the message that
the HW is being touched and improve the module param description. To
avoid confusion, the enable_display is renamed everywhere, not only in
the module param. New description for the parameters:
disable_display:Disable display (default: false) (bool)
probe_display:Probe display HW, otherwise it's left untouched (default: true) (bool)
Reviewed-by: Matt Roper <matthew.d.roper at intel.com>
Acked-by: Jani Nikula <jani.nikula at intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240808180154.2495634-1-lucas.demarchi@intel.com
Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
+ /mt/dim checkpatch eb97e8bfe4c4f91fee7cfa354d300164f605aa83 drm-intel
120d782a897b drm/xe: Rename enable_display module param
-:28: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#28:
probe_display:Probe display HW, otherwise it's left untouched (default: true) (bool)
total: 0 errors, 1 warnings, 0 checks, 255 lines checked
More information about the Intel-xe
mailing list