✗ CI.checkpatch: warning for drm/xe: fixes and debug improvements for GSC load

Patchwork patchwork at emeril.freedesktop.org
Tue Aug 13 23:17:53 UTC 2024


== Series Details ==

Series: drm/xe: fixes and debug improvements for GSC load
URL   : https://patchwork.freedesktop.org/series/137270/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
9fe5037901cabbcdf27a6fe0dfb047ca1474d363
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit a3d4fa52800008afc59b439ff6d97b67f32d205b
Author: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
Date:   Tue Aug 13 16:11:47 2024 -0700

    drm/xe/gsc: Add debugfs to print GSC info
    
    This is useful for debug, in case something goes wrong with the GSC. The
    info includes the version information and the current value of the HECI1
    status registers.
    
    Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
    Cc: John Harrison <John.C.Harrison at Intel.com>
    Cc: Alan Previn <alan.previn.teres.alexis at intel.com>
+ /mt/dim checkpatch 02c35fc4e126599bc57696d25d9b78d612a7a847 drm-intel
dd2fd1911c3f drm/xe/gsc: Do not attempt to load the GSC multiple times
aba4330e3cb8 drm/xe/gsc: Fix FW status if the firmware is already loaded
3c1a81ac3f23 drm/xe/gsc: Track the platform in the compatibility version
-:58: WARNING:MACRO_ARG_UNUSED: Argument 'a' is not used in function-like macro
#58: FILE: drivers/gpu/drm/xe/xe_uc_fw.c:145:
+#define fw_filename_gsc(dir_, uc_, shortname_, a, b, c)				\
+	MAKE_FW_PATH(dir_, uc_, shortname_, "_" __stringify(b))

-:58: WARNING:MACRO_ARG_UNUSED: Argument 'c' is not used in function-like macro
#58: FILE: drivers/gpu/drm/xe/xe_uc_fw.c:145:
+#define fw_filename_gsc(dir_, uc_, shortname_, a, b, c)				\
+	MAKE_FW_PATH(dir_, uc_, shortname_, "_" __stringify(b))

-:67: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'a' - possible side-effects?
#67: FILE: drivers/gpu/drm/xe/xe_uc_fw.c:157:
+#define uc_fw_entry_gsc(dir_, uc_, shortname_, a, b, c)				\
+	{ fw_filename_gsc(dir_, uc_, shortname_, a, b, c),			\
+	  a, b, c }

-:67: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'b' - possible side-effects?
#67: FILE: drivers/gpu/drm/xe/xe_uc_fw.c:157:
+#define uc_fw_entry_gsc(dir_, uc_, shortname_, a, b, c)				\
+	{ fw_filename_gsc(dir_, uc_, shortname_, a, b, c),			\
+	  a, b, c }

-:67: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'c' - possible side-effects?
#67: FILE: drivers/gpu/drm/xe/xe_uc_fw.c:157:
+#define uc_fw_entry_gsc(dir_, uc_, shortname_, a, b, c)				\
+	{ fw_filename_gsc(dir_, uc_, shortname_, a, b, c),			\
+	  a, b, c }

total: 0 errors, 2 warnings, 3 checks, 57 lines checked
a3d4fa528000 drm/xe/gsc: Add debugfs to print GSC info
-:82: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#82: FILE: drivers/gpu/drm/xe/xe_gsc.c:620:
+	drm_printf(p, "\nHECI1 FWSTS: 0x%08x 0x%08x 0x%08x 0x%08x 0x%08x 0x%08x\n",
+			xe_mmio_read32(gt, HECI_FWSTS1(MTL_GSC_HECI1_BASE)),

-:111: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#111: 
new file mode 100644

total: 0 errors, 1 warnings, 1 checks, 173 lines checked




More information about the Intel-xe mailing list