✗ CI.checkpatch: warning for drm/xe: Add driver load error injection (rev2)

Patchwork patchwork at emeril.freedesktop.org
Wed Aug 14 18:13:55 UTC 2024


== Series Details ==

Series: drm/xe: Add driver load error injection (rev2)
URL   : https://patchwork.freedesktop.org/series/137314/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
9fe5037901cabbcdf27a6fe0dfb047ca1474d363
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit dfecd09d0117573004405393612db81fee75476f
Author: Francois Dugast <francois.dugast at intel.com>
Date:   Wed Aug 14 20:08:35 2024 +0200

    drm/xe: Add driver load error injection
    
    Port over i915 driver load error injection.
    
    v2: Fix style and build errors, modparam to 0 after probe, rename to
        xe_device_inject_driver_probe_error, check type when compiled out,
        add _return macro, move some uses to the beginning of the function
    v3: Rebase
    
    Signed-off-by: Matthew Brost <matthew.brost at intel.com>
    Signed-off-by: Francois Dugast <francois.dugast at intel.com>
    Cc: Lucas De Marchi <lucas.demarchi at intel.com>
+ /mt/dim checkpatch 79d8c33863d99ac1b04afcce123bdc2ad919e993 drm-intel
dfecd09d0117 drm/xe: Add driver load error injection
-:105: WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#105: FILE: drivers/gpu/drm/xe/xe_device.h:188:
+#define xe_device_inject_driver_probe_return(__xe) \
+	({ if (__xe_device_inject_driver_probe_error(__xe, XE_DEVICE_INJECTED_ERR, 0, __func__, \
+						     __LINE__) == XE_DEVICE_INJECTED_ERR) \
+			return XE_DEVICE_INJECTED_ERR; })

-:240: WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#240: FILE: drivers/gpu/drm/xe/xe_module.c:57:
+module_param_named_unsafe(inject_driver_probe_error, xe_modparam.inject_driver_probe_error, int, 0600);

total: 0 errors, 2 warnings, 0 checks, 256 lines checked




More information about the Intel-xe mailing list