[PATCH] drm/xe: Use for_each_remote_tile rather than manual check

Lucas De Marchi lucas.demarchi at intel.com
Fri Aug 16 05:06:12 UTC 2024


On Thu, Aug 15, 2024 at 09:02:08PM GMT, Matthew Brost wrote:
>Replace for_each_tile plus a check against primary tile with
>for_each_remote_tile in tiles_fini. The latter macro does this for us.
>
>Signed-off-by: Matthew Brost <matthew.brost at intel.com>


Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

Lucas De Marchi

>---
> drivers/gpu/drm/xe/xe_mmio.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/gpu/drm/xe/xe_mmio.c b/drivers/gpu/drm/xe/xe_mmio.c
>index f5bdb540e823..3fd462fda625 100644
>--- a/drivers/gpu/drm/xe/xe_mmio.c
>+++ b/drivers/gpu/drm/xe/xe_mmio.c
>@@ -29,9 +29,8 @@ static void tiles_fini(void *arg)
> 	struct xe_tile *tile;
> 	int id;
>
>-	for_each_tile(tile, xe, id)
>-		if (tile != xe_device_get_root_tile(xe))
>-			tile->mmio.regs = NULL;
>+	for_each_remote_tile(tile, xe, id)
>+		tile->mmio.regs = NULL;
> }
>
> /*
>-- 
>2.34.1
>


More information about the Intel-xe mailing list