[PATCH 01/12] drm/xe: Removed unused xe_ggtt_printk

[Lucas De Marchi]

On Fri, Aug 16, 2024 at 11:02:32AM GMT, Rodrigo Vivi wrote:
>Apparently this was only useful when enabling ggtt support
>for the very first time and never used again.
>It is also not useful now that we have the ggtt_dump available
>through debugfs.
>
>Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray at intel.com>
>Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>


Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

Lucas De Marchi

>---
> drivers/gpu/drm/xe/xe_ggtt.c | 20 --------------------
> drivers/gpu/drm/xe/xe_ggtt.h |  1 -
> 2 files changed, 21 deletions(-)
>
>diff --git a/drivers/gpu/drm/xe/xe_ggtt.c b/drivers/gpu/drm/xe/xe_ggtt.c
>index 0cdbc1296e88..add14f3dea1f 100644
>--- a/drivers/gpu/drm/xe/xe_ggtt.c
>+++ b/drivers/gpu/drm/xe/xe_ggtt.c
>@@ -314,26 +314,6 @@ static void xe_ggtt_invalidate(struct xe_ggtt *ggtt)
> 	ggtt_invalidate_gt_tlb(ggtt->tile->media_gt);
> }
>
>-void xe_ggtt_printk(struct xe_ggtt *ggtt, const char *prefix)
>-{
>-	u16 pat_index = tile_to_xe(ggtt->tile)->pat.idx[XE_CACHE_WB];
>-	u64 addr, scratch_pte;
>-
>-	scratch_pte = ggtt->pt_ops->pte_encode_bo(ggtt->scratch, 0, pat_index);
>-
>-	printk("%sGlobal GTT:", prefix);
>-	for (addr = 0; addr < ggtt->size; addr += XE_PAGE_SIZE) {
>-		unsigned int i = addr / XE_PAGE_SIZE;
>-
>-		xe_tile_assert(ggtt->tile, addr <= U32_MAX);
>-		if (ggtt->gsm[i] == scratch_pte)
>-			continue;
>-
>-		printk("%s    ggtt[0x%08x] = 0x%016llx",
>-		       prefix, (u32)addr, ggtt->gsm[i]);
>-	}
>-}
>-
> static void xe_ggtt_dump_node(struct xe_ggtt *ggtt,
> 			      const struct drm_mm_node *node, const char *description)
> {
>diff --git a/drivers/gpu/drm/xe/xe_ggtt.h b/drivers/gpu/drm/xe/xe_ggtt.h
>index 6a96fd54bf60..2546bab97507 100644
>--- a/drivers/gpu/drm/xe/xe_ggtt.h
>+++ b/drivers/gpu/drm/xe/xe_ggtt.h
>@@ -12,7 +12,6 @@ struct drm_printer;
>
> int xe_ggtt_init_early(struct xe_ggtt *ggtt);
> int xe_ggtt_init(struct xe_ggtt *ggtt);
>-void xe_ggtt_printk(struct xe_ggtt *ggtt, const char *prefix);
>
> int xe_ggtt_balloon(struct xe_ggtt *ggtt, u64 start, u64 size, struct drm_mm_node *node);
> void xe_ggtt_deballoon(struct xe_ggtt *ggtt, struct drm_mm_node *node);
>-- 
>2.46.0
>