[PATCH v2 4/6] drm/xe: Move hw_engine_fini to devm managed

Lucas De Marchi lucas.demarchi at intel.com
Tue Aug 20 20:48:39 UTC 2024


On Tue, Aug 20, 2024 at 10:29:56AM GMT, Matthew Brost wrote:
>Kernel BOs are destroyed with GGTT mappings, this is hardware
>interaction so use devm.
>
>Signed-off-by: Matthew Brost <matthew.brost at intel.com>


Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

Lucas De Marchi

>---
> drivers/gpu/drm/xe/xe_hw_engine.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/xe/xe_hw_engine.c b/drivers/gpu/drm/xe/xe_hw_engine.c
>index aa9b2b16a6e0..18980238a2ea 100644
>--- a/drivers/gpu/drm/xe/xe_hw_engine.c
>+++ b/drivers/gpu/drm/xe/xe_hw_engine.c
>@@ -267,7 +267,7 @@ static const struct engine_info engine_infos[] = {
> 	},
> };
>
>-static void hw_engine_fini(struct drm_device *drm, void *arg)
>+static void hw_engine_fini(void *arg)
> {
> 	struct xe_hw_engine *hwe = arg;
>
>@@ -585,7 +585,7 @@ static int hw_engine_init(struct xe_gt *gt, struct xe_hw_engine *hwe,
> 	if (xe->info.has_usm && hwe->class == XE_ENGINE_CLASS_COPY)
> 		gt->usm.reserved_bcs_instance = hwe->instance;
>
>-	return drmm_add_action_or_reset(&xe->drm, hw_engine_fini, hwe);
>+	return devm_add_action_or_reset(xe->drm.dev, hw_engine_fini, hwe);
>
> err_kernel_lrc:
> 	xe_lrc_put(hwe->kernel_lrc);
>-- 
>2.34.1
>


More information about the Intel-xe mailing list