✗ CI.checkpatch: warning for series starting with [01/12] drm/xe: Removed unused xe_ggtt_printk
Patchwork
patchwork at emeril.freedesktop.org
Tue Aug 20 21:41:20 UTC 2024
== Series Details ==
Series: series starting with [01/12] drm/xe: Removed unused xe_ggtt_printk
URL : https://patchwork.freedesktop.org/series/137537/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
9fe5037901cabbcdf27a6fe0dfb047ca1474d363
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 45fffa6530c8cb76d30de6a0faada7267612371a
Author: Rodrigo Vivi <rodrigo.vivi at intel.com>
Date: Tue Aug 20 16:25:47 2024 -0400
drm/xe: Fix missing runtime outer protection for ggtt_remove_node
Defer the ggtt node removal to a thread if runtime_pm is not active.
The ggtt node removal can be called from multiple places, including
places where we cannot protect with outer callers and places we are
within other locks. So, try to grab the runtime reference if the
device is already active, otherwise defer the removal to a separate
thread from where we are sure we can wake the device up.
v2: - use xe wq instead of system wq (Matt and CI)
- Avoid GFP_KERNEL to be future proof since this removal can
be called from outside our drivers and we don't want to block
if atomic is needed. (Brost)
v3: amend forgot chunk declaring xe_device.
v4: Use a xe_ggtt_region to encapsulate the node and remova info,
wihtout the need for any memory allocation at runtime.
v5: Actually fill the delayed_removal.invalidate (Brost)
v6: - Ensure that ggtt_region is not freed before work finishes (Auld)
- Own wq to ensures that the queued works are flushed before
ggtt_fini (Brost)
v7: also free ggtt_region on early !bound return (Auld)
v8: Address the null deref (CI)
v9: Based on the new xe_ggtt_node for the proper care of the lifetime
of the object.
v10: Redo the lost v5 change. (Brost)
v11: Simplify the invalidate_on_remove (Lucas)
Cc: Matthew Auld <matthew.auld at intel.com>
Cc: Paulo Zanoni <paulo.r.zanoni at intel.com>
Cc: Francois Dugast <francois.dugast at intel.com>
Cc: Thomas Hellström <thomas.hellstrom at linux.intel.com>
Cc: Matthew Brost <matthew.brost at intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
+ /mt/dim checkpatch 0729ba6a553ae595a4092ceb27300ea218c2efae drm-intel
f47c20026346 drm/xe: Removed unused xe_ggtt_printk
04eda124b8cf drm/xe: Introduce GGTT documentation
b8277000b186 drm/xe: Remove unnecessary drm_mm.h includes
e688e7401a41 drm/{i915, xe}: Avoid direct inspection of dpt_vma from outside dpt
5e4e5089ff92 drm/xe: Encapsulate drm_mm_node inside xe_ggtt_node
b2de25b0a81b drm/xe: Rename xe_ggtt_node related functions
8436bb45742f drm/xe: Limit drm_mm_node_allocated access to xe_ggtt_node
6814d0607bc9 drm/xe: Introduce xe_ggtt_largest_hole
df57168028b2 drm/xe: Introduce xe_ggtt_print_holes
8ef4940d2c5e drm/xe: Refactor xe_ggtt balloon functions to make the node clear
10f152fa459d drm/xe: Make xe_ggtt_node struct independent
-:715: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#715: FILE: drivers/gpu/drm/xe/xe_gt_sriov_vf.c:548:
+ err = vf_balloon_ggtt_node(ggtt, tile->sriov.vf.ggtt_balloon[0],
start, end);
-:724: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#724: FILE: drivers/gpu/drm/xe/xe_gt_sriov_vf.c:557:
+ err = vf_balloon_ggtt_node(ggtt, tile->sriov.vf.ggtt_balloon[1],
start, end);
total: 0 errors, 0 warnings, 2 checks, 631 lines checked
45fffa6530c8 drm/xe: Fix missing runtime outer protection for ggtt_remove_node
More information about the Intel-xe
mailing list