[PATCH 03/21] drm/xe/eudebug: Introduce eudebug support

[Mika Kuoppala]

Zbigniew Kempczyński <zbigniew.kempczynski at intel.com> writes:

> On Fri, Jul 26, 2024 at 05:08:00PM +0300, Mika Kuoppala wrote:
>
> <cut>
>
>> +
>> +static int
>> +xe_eudebug_attach(struct xe_device *xe, struct xe_eudebug *d,
>> +		  const pid_t pid_nr)
>> +{
>> +	struct task_struct *target;
>> +	struct xe_eudebug *iter;
>> +	kuid_t uid = current_uid();
>> +	int ret = 0;
>> +
>> +	target = find_get_target(pid_nr);
>> +	if (!target)
>> +		return -ENOENT;
>
> This goes outside and is returned via ioctl() what reminds me some LKML
> thread this code is reserved for file operations only.

Yes, my excuse here is that I try to mimic what other xe code
does. And I can't think of other than EINVAL here.
-Mika

>
> --
> Zbigniew