✗ CI.checkpatch: warning for drm/xe: Align all 64k VRAM buffers physically when multiple of 64k.

[Patchwork]

== Series Details ==

Series: drm/xe: Align all 64k VRAM buffers physically when multiple of 64k.
URL   : https://patchwork.freedesktop.org/series/137649/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
9fe5037901cabbcdf27a6fe0dfb047ca1474d363
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 38667b916ae4c2f698c5715da0bdfc3e0f0e16db
Author: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
Date:   Thu Aug 22 16:23:46 2024 +0200

    drm/xe: Align all 64k VRAM buffers physically when multiple of 64k.
    
    For CCS formats on affected platforms, CCS can be used freely, but
    display engine requires a multiple of 64k physical pages. No other
    changes are needed.
    
    At the BO creation time we don't know if the BO will be used for CCS
    or not. If the scanout flag is set, and the BO is a multiple of 64k,
    we take the safe route and force the physical alignment of 64k pages.
    
    If the BO is not a multiple of 64k, or the scanout flag was not set
    at BO creation, we reject it for usage as CCS in display. The physical
    pages are likely not aligned correctly, and this will cause corruption
    when used as FB.
    
    This is a slightly different approach from my previous patch. Instead
    of requiring a scanout flag at FB creation, we now make all buffers of
    the right size physically aligned correctly, so no change from userspace
    is needed.
    
    It will be interesting to see if it affects performance in any way,
    could potentially even improve things with 64k PTE's.
    
    Inspired by Zbigniews patch.
    
    Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
    Co-developed-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
    Cc: Matthew Auld <matthew.auld at intel.com>
    Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
    Cc: Thomas Hellström <thomas.hellstrom at linux.intel.com>
    Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
    Cc: Juha-Pekka Heikkilä <juha-pekka.heikkila at intel.com>
+ /mt/dim checkpatch 882c26c7017bdcc4eca493c7bf1ffb034d40be02 drm-intel
38667b916ae4 drm/xe: Align all 64k VRAM buffers physically when multiple of 64k.
-:34: WARNING:BAD_SIGN_OFF: Co-developed-by: must be immediately followed by Signed-off-by:
#34: 
Co-developed-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
Cc: Matthew Auld <matthew.auld at intel.com>

-:50: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#50: FILE: drivers/gpu/drm/xe/display/intel_fb_bo.c:32:
+	if (XE_IOCTL_DBG(xe, mode_cmd->modifier[0] == I915_FORMAT_MOD_4_TILED_BMG_CCS &&
+			     !(bo->flags & XE_BO_FLAG_NEEDS_64K)))

total: 0 errors, 1 warnings, 1 checks, 35 lines checked