✗ CI.checkpatch: warning for drm/xe: Align all VRAM scanout buffers to 64k physical pages when needed. (rev3)
Patchwork
patchwork at emeril.freedesktop.org
Mon Aug 26 18:58:02 UTC 2024
== Series Details ==
Series: drm/xe: Align all VRAM scanout buffers to 64k physical pages when needed. (rev3)
URL : https://patchwork.freedesktop.org/series/137662/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
9fe5037901cabbcdf27a6fe0dfb047ca1474d363
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 0c45e9747196dc7e04db95f5900aebd7027341fc
Author: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
Date: Mon Aug 26 19:01:16 2024 +0200
drm/xe: Align all VRAM scanout buffers to 64k physical pages when needed.
For CCS formats on affected platforms, CCS can be used freely, but
display engine requires a multiple of 64k physical pages. No other
changes are needed.
At the BO creation time we don't know if the BO will be used for CCS
or not. If the scanout flag is set, and the BO is a multiple of 64k,
we take the safe route and force the physical alignment of 64k pages.
If the BO is not a multiple of 64k, or the scanout flag was not set
at BO creation, we reject it for usage as CCS in display. The physical
pages are likely not aligned correctly, and this will cause corruption
when used as FB.
The scanout flag and size being a multiple of 64k are used together
to enforce 64k physical placement.
VM_BIND is completely unaffected, mappings to a VM can still be aligned
to 4k, just like for normal buffers.
Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
Cc: Matthew Auld <matthew.auld at intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
Cc: Thomas Hellström <thomas.hellstrom at linux.intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
Cc: Juha-Pekka Heikkilä <juha-pekka.heikkila at intel.com>
+ /mt/dim checkpatch a98a350b5396d30458c26b4f31d7c4f4f9b1da90 drm-intel
f40f9a050ddf drm/i915/display: Plane capability for 64k phys alignment
0c45e9747196 drm/xe: Align all VRAM scanout buffers to 64k physical pages when needed.
-:58: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#58: FILE: drivers/gpu/drm/xe/display/intel_fb_bo.c:37:
+ if (XE_IOCTL_DBG(xe, intel_fb_needs_64k_phys(mode_cmd->modifier[0]) &&
+ !(bo->flags & XE_BO_FLAG_NEEDS_64K)))
total: 0 errors, 0 warnings, 1 checks, 51 lines checked
More information about the Intel-xe
mailing list