✗ CI.checkpatch: warning for drm/xe/pmu: Enable PMU interface (rev10)

Patchwork patchwork at emeril.freedesktop.org
Tue Aug 27 17:10:06 UTC 2024


== Series Details ==

Series: drm/xe/pmu: Enable PMU interface (rev10)
URL   : https://patchwork.freedesktop.org/series/119504/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
9fe5037901cabbcdf27a6fe0dfb047ca1474d363
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 6cc8b540143aed3e575ef1f1799705ab74833e84
Author: Vinay Belgaumkar <vinay.belgaumkar at intel.com>
Date:   Tue Aug 27 09:41:07 2024 -0700

    drm/xe/pmu: Add GT frequency events
    
    Define PMU events for GT freq (actual and requested).
    PMU events being added -
    
      xe_0000_00_02.0/actual-frequency-gt0/              [Kernel PMU event]
      xe_0000_00_02.0/actual-frequency-gt1/              [Kernel PMU event]
      xe_0000_00_02.0/requested-frequency-gt0/           [Kernel PMU event]
      xe_0000_00_02.0/requested-frequency-gt1/           [Kernel PMU event]
    
    These events will aggregate freq in Mhz just like sysfs. The
    implementation has been borrowed from i915 driver.
    
    Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
    Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar at intel.com>
+ /mt/dim checkpatch 2c3fbd94c8b2eda2275211dfa8ead639a4e3e161 drm-intel
1357293da832 drm/xe/pmu: Enable PMU interface
-:129: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#129: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 742 lines checked
3cd1f6698be8 drm/xe/pmu: Define and init a timer
-:131: ERROR:CODE_INDENT: code indent should use tabs where possible
#131: FILE: drivers/gpu/drm/xe/xe_pmu.c:189:
+        if (!pmu->timer_enabled && pmu_needs_timer(pmu)) {$

-:131: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#131: FILE: drivers/gpu/drm/xe/xe_pmu.c:189:
+        if (!pmu->timer_enabled && pmu_needs_timer(pmu)) {$

-:137: ERROR:CODE_INDENT: code indent should use tabs where possible
#137: FILE: drivers/gpu/drm/xe/xe_pmu.c:195:
+        }$

-:137: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#137: FILE: drivers/gpu/drm/xe/xe_pmu.c:195:
+        }$

-:256: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Vinay Belgaumkar <vinay.belgaumkar at intel.com>' != 'Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar at ntel.com>'

total: 2 errors, 3 warnings, 0 checks, 216 lines checked
1e0c7640fafe drm/xe/pmu: Add GT C6 events
-:258: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#258: FILE: drivers/gpu/drm/xe/xe_pmu.c:694:
+		store_sample(pmu, j, __XE_SAMPLE_RC6_LAST_REPORTED,
+				     val);

total: 0 errors, 0 warnings, 1 checks, 292 lines checked
6cc8b540143a drm/xe/pmu: Add GT frequency events
-:48: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#48: FILE: drivers/gpu/drm/xe/xe_pmu.c:76:
+			     BITS_PER_TYPE(typeof_member(struct xe_pmu,
+						 enable)) - 1);

total: 0 errors, 0 warnings, 1 checks, 245 lines checked




More information about the Intel-xe mailing list