[PATCH 0/4] drm/xe/pmu: Enable PMU interface

Lucas De Marchi lucas.demarchi at intel.com
Wed Aug 28 19:24:59 UTC 2024


On Tue, Aug 27, 2024 at 09:41:03AM GMT, Vinay Belgaumkar wrote:
>Port PMU event capture capability to Xe driver. This is being
>requested by users of tools like gputop or turbostat who
>use these PMU events to monitor GT freq and residencies.
>
>First patch is from a previously done review-
>https://patchwork.freedesktop.org/series/119504/ and the rest
>of the patches are ported from the i915 driver.
>
>There is an attempt to break up the code into a few chunks
>so that everything is not a single blob. Basic PMU setup is
>done first, followed by timer init and then C6 and frequency
>events separately. One change is we now provide a modparam to
>control sampling frequency.
>
>A patch for IGT tests for this is in progress and will be
>posted in a couple of days.
>
>Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
>Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar at intel.com>

FWIW since this is copying parts of the i915 implementation,
I'm going to block it until that is fixed:
https://lore.kernel.org/intel-gfx/20240722210648.80892-1-lucas.demarchi@intel.com/

Because we don't need to replicate the same mistakes and then have to
fix both. I should go back to that and send a v2 soon, probably by end
of this week.

Lucas De Marchi


More information about the Intel-xe mailing list