[PATCH 4/4] drm/xe/gsc: Add debugfs to print GSC info

Daniele Ceraolo Spurio daniele.ceraolospurio at intel.com
Wed Aug 28 21:25:09 UTC 2024



On 8/23/2024 6:02 PM, Julia Filipchuk wrote:
> LGTM
>
> Reviewed-by: Julia Filipchuk <julia.filipchuk at intel.com>
>
>> +	for (i = 0; i < ARRAY_SIZE(debugfs_list); ++i)
>> +		local[i].data = gsc;
> Behavior looks correct. This array is length 1 here so the mapping
> works. Would a manual assignment be more clear for intended mapping?
>
> local[0].data = gsc;

The idea is that this way we can just add new entries to the table if we 
need to without having to update the code here to manually set data for 
each entry.

Daniele

>
>
>



More information about the Intel-xe mailing list