✗ CI.checkpatch: warning for drm/xe: fixes and debug improvements for GSC load (rev2)

[Patchwork]

== Series Details ==

Series: drm/xe: fixes and debug improvements for GSC load (rev2)
URL   : https://patchwork.freedesktop.org/series/137270/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
9fe5037901cabbcdf27a6fe0dfb047ca1474d363
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit c714be7a70c3d454065535985163c15e7df98fe4
Author: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
Date:   Wed Aug 28 14:51:57 2024 -0700

    drm/xe/gsc: Add debugfs to print GSC info
    
    This is useful for debug, in case something goes wrong with the GSC. The
    info includes the version information and the current value of the HECI1
    status registers.
    
    Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
    Cc: John Harrison <John.C.Harrison at Intel.com>
    Cc: Alan Previn <alan.previn.teres.alexis at intel.com>
    Reviewed-by: Julia Filipchuk <julia.filipchuk at intel.com>
+ /mt/dim checkpatch 6b66ec881f7ae385f90fe6ad8c6ebef112873a17 drm-intel
056af5faf97c drm/xe/gsc: Do not attempt to load the GSC multiple times
2e1cea6508b3 drm/xe/gsc: Fix FW status if the firmware is already loaded
4d29c7445f6b drm/xe/gsc: Track the platform in the compatibility version
-:59: WARNING:MACRO_ARG_UNUSED: Argument 'a' is not used in function-like macro
#59: FILE: drivers/gpu/drm/xe/xe_uc_fw.c:145:
+#define fw_filename_gsc(dir_, uc_, shortname_, a, b, c)				\
+	MAKE_FW_PATH(dir_, uc_, shortname_, "_" __stringify(b))

-:59: WARNING:MACRO_ARG_UNUSED: Argument 'c' is not used in function-like macro
#59: FILE: drivers/gpu/drm/xe/xe_uc_fw.c:145:
+#define fw_filename_gsc(dir_, uc_, shortname_, a, b, c)				\
+	MAKE_FW_PATH(dir_, uc_, shortname_, "_" __stringify(b))

-:68: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'a' - possible side-effects?
#68: FILE: drivers/gpu/drm/xe/xe_uc_fw.c:157:
+#define uc_fw_entry_gsc(dir_, uc_, shortname_, a, b, c)				\
+	{ fw_filename_gsc(dir_, uc_, shortname_, a, b, c),			\
+	  a, b, c }

-:68: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'b' - possible side-effects?
#68: FILE: drivers/gpu/drm/xe/xe_uc_fw.c:157:
+#define uc_fw_entry_gsc(dir_, uc_, shortname_, a, b, c)				\
+	{ fw_filename_gsc(dir_, uc_, shortname_, a, b, c),			\
+	  a, b, c }

-:68: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'c' - possible side-effects?
#68: FILE: drivers/gpu/drm/xe/xe_uc_fw.c:157:
+#define uc_fw_entry_gsc(dir_, uc_, shortname_, a, b, c)				\
+	{ fw_filename_gsc(dir_, uc_, shortname_, a, b, c),			\
+	  a, b, c }

total: 0 errors, 2 warnings, 3 checks, 57 lines checked
c714be7a70c3 drm/xe/gsc: Add debugfs to print GSC info
-:83: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#83: FILE: drivers/gpu/drm/xe/xe_gsc.c:614:
+	drm_printf(p, "\nHECI1 FWSTS: 0x%08x 0x%08x 0x%08x 0x%08x 0x%08x 0x%08x\n",
+			xe_mmio_read32(gt, HECI_FWSTS1(MTL_GSC_HECI1_BASE)),

-:112: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#112: 
new file mode 100644

total: 0 errors, 1 warnings, 1 checks, 173 lines checked