[PATCH 4/5] drmxe/reg_sr: Convert whitelist to gt logging

Matt Roper matthew.d.roper at intel.com
Thu Dec 5 19:27:46 UTC 2024


On Thu, Dec 05, 2024 at 10:22:39AM -0800, Lucas De Marchi wrote:
> Part of the whitelist printing was already using gt-logging - convert
> the rest.
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>

Reviewed-by: Matt Roper <matthew.d.roper at intel.com>

> ---
>  drivers/gpu/drm/xe/xe_reg_sr.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_reg_sr.c b/drivers/gpu/drm/xe/xe_reg_sr.c
> index f982c1cdb369c..ea958400a15a1 100644
> --- a/drivers/gpu/drm/xe/xe_reg_sr.c
> +++ b/drivers/gpu/drm/xe/xe_reg_sr.c
> @@ -196,7 +196,6 @@ void xe_reg_sr_apply_whitelist(struct xe_hw_engine *hwe)
>  {
>  	struct xe_reg_sr *sr = &hwe->reg_whitelist;
>  	struct xe_gt *gt = hwe->gt;
> -	struct xe_device *xe = gt_to_xe(gt);
>  	struct xe_reg_sr_entry *entry;
>  	struct drm_printer p;
>  	u32 mmio_base = hwe->mmio_base;
> @@ -204,13 +203,13 @@ void xe_reg_sr_apply_whitelist(struct xe_hw_engine *hwe)
>  	unsigned int slot = 0;
>  	unsigned int fw_ref;
>  
> -	drm_dbg(&xe->drm, "Whitelisting %s registers\n", sr->name);
> +	xe_gt_dbg(gt, "Whitelisting %s registers\n", sr->name);
>  
>  	fw_ref = xe_force_wake_get(gt_to_fw(gt), XE_FORCEWAKE_ALL);
>  	if (!xe_force_wake_ref_has_domain(fw_ref, XE_FORCEWAKE_ALL))
>  		goto err_force_wake;
>  
> -	p = drm_dbg_printer(&xe->drm, DRM_UT_DRIVER, NULL);
> +	p = xe_gt_dbg_printer(gt);
>  	xa_for_each(&sr->xa, reg, entry) {
>  		if (slot == RING_MAX_NONPRIV_SLOTS) {
>  			xe_gt_err(gt,
> @@ -238,7 +237,7 @@ void xe_reg_sr_apply_whitelist(struct xe_hw_engine *hwe)
>  
>  err_force_wake:
>  	xe_force_wake_put(gt_to_fw(gt), fw_ref);
> -	drm_err(&xe->drm, "Failed to apply, err=-ETIMEDOUT\n");
> +	xe_gt_err(gt, "Failed to apply, err=-ETIMEDOUT\n");
>  }
>  
>  /**
> -- 
> 2.47.0
> 

-- 
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation


More information about the Intel-xe mailing list