[PATCH v8 2/3] drm/xe/pmu: Add GT C6 events

Lucas De Marchi lucas.demarchi at intel.com
Tue Dec 10 22:31:04 UTC 2024


On Fri, Dec 06, 2024 at 04:52:19PM -0800, Vinay Belgaumkar wrote:
>Provide a PMU interface for GT C6 residency counters. The implementation
>is ported over from the i915 PMU code. Residency is provided in units of
>ms(like sysfs entry in - /sys/class/drm/card0/device/tile0/gt0/gtidle).
>
>Sample usage and output-
>
>$ perf list | grep c6
>
>  xe_0000_00_02.0/c6-residency/                 [Kernel PMU event]
>
>$ ls /sys/bus/event_source/devices/xe_0000_00_02.0/format/
>  xe_eventid  xe_gt_id

redundant xe prefix... we could live without it.

>$ cat /sys/bus/event_source/devices/xe_0000_00_02.0/format/*
>  config:0-20

if you are using just 21 bits of the first config,

>  config1:0-2

why do you go with the second config here?

>
>$ perf stat -e xe_0000_00_02.0/c6-residency,xe_gt_id=0/ -I1000
>
>$           time     counts unit events
>     1.001183454       1001 ms   xe_0000_00_02.0/c6-residency,xe_gt_id=0/
>     2.004434757       1002 ms   xe_0000_00_02.0/c6-residency,xe_gt_id=0/

that looks much better than before

>
>v2: Checkpatch fix, move timer code to next patch
>v3: Fix kunit issue
>v4: Fix for locking issue, fix review comments (Riana)
>v5: Add xe_pmu_disable() function to reset enable_count
>v6: Change rc6 to c6 (Riana)
>v7: Fix another comment format
>v8: Replace RC6 with C6 (Riana)
>v9: Define sampling freq in next patch
>
>Cc: Lucas De Marchi <lucas.demarchi at intel.com>
>Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
>Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar at intel.com>
>---
> drivers/gpu/drm/xe/xe_gt.c        |   3 +
> drivers/gpu/drm/xe/xe_gt_idle.c   |  17 ++-
> drivers/gpu/drm/xe/xe_gt_idle.h   |   1 +
> drivers/gpu/drm/xe/xe_pmu.c       | 214 ++++++++++++++++++++++++++++++
> drivers/gpu/drm/xe/xe_pmu.h       |   2 +
> drivers/gpu/drm/xe/xe_pmu_types.h |  57 ++++++++
> 6 files changed, 289 insertions(+), 5 deletions(-)
>
>diff --git a/drivers/gpu/drm/xe/xe_gt.c b/drivers/gpu/drm/xe/xe_gt.c
>index d6744be01a68..3321f1b72c6e 100644
>--- a/drivers/gpu/drm/xe/xe_gt.c
>+++ b/drivers/gpu/drm/xe/xe_gt.c
>@@ -47,6 +47,7 @@
> #include "xe_mmio.h"
> #include "xe_pat.h"
> #include "xe_pm.h"
>+#include "xe_pmu.h"
> #include "xe_mocs.h"
> #include "xe_reg_sr.h"
> #include "xe_ring_ops.h"
>@@ -877,6 +878,8 @@ int xe_gt_suspend(struct xe_gt *gt)
>
> 	xe_gt_idle_disable_pg(gt);
>
>+	xe_pmu_suspend(gt);
>+
> 	xe_gt_disable_host_l2_vram(gt);
>
> 	xe_force_wake_put(gt_to_fw(gt), fw_ref);
>diff --git a/drivers/gpu/drm/xe/xe_gt_idle.c b/drivers/gpu/drm/xe/xe_gt_idle.c
>index fd80afeef56a..47b5696c7137 100644
>--- a/drivers/gpu/drm/xe/xe_gt_idle.c
>+++ b/drivers/gpu/drm/xe/xe_gt_idle.c
>@@ -275,18 +275,25 @@ static ssize_t idle_status_show(struct device *dev,
> }
> static DEVICE_ATTR_RO(idle_status);
>
>+u64 xe_gt_idle_residency(struct xe_gt_idle *gtidle)
>+{
>+	struct xe_guc_pc *pc = gtidle_to_pc(gtidle);
>+
>+	return get_residency_ms(gtidle, gtidle->idle_residency(pc));
>+}
>+
> static ssize_t idle_residency_ms_show(struct device *dev,
> 				      struct device_attribute *attr, char *buff)
> {
> 	struct xe_gt_idle *gtidle = dev_to_gtidle(dev);
>-	struct xe_guc_pc *pc = gtidle_to_pc(gtidle);
>+	struct xe_gt *gt = gtidle_to_gt(gtidle);
> 	u64 residency;
>
>-	xe_pm_runtime_get(pc_to_xe(pc));
>-	residency = gtidle->idle_residency(pc);
>-	xe_pm_runtime_put(pc_to_xe(pc));
>+	xe_pm_runtime_get(gt_to_xe(gt));
>+	residency = xe_gt_idle_residency(gtidle);
>+	xe_pm_runtime_put(gt_to_xe(gt));
>
>-	return sysfs_emit(buff, "%llu\n", get_residency_ms(gtidle, residency));
>+	return sysfs_emit(buff, "%llu\n", residency);
> }
> static DEVICE_ATTR_RO(idle_residency_ms);
>
>diff --git a/drivers/gpu/drm/xe/xe_gt_idle.h b/drivers/gpu/drm/xe/xe_gt_idle.h
>index 4455a6501cb0..795a02c9d89c 100644
>--- a/drivers/gpu/drm/xe/xe_gt_idle.h
>+++ b/drivers/gpu/drm/xe/xe_gt_idle.h
>@@ -17,5 +17,6 @@ void xe_gt_idle_disable_c6(struct xe_gt *gt);
> void xe_gt_idle_enable_pg(struct xe_gt *gt);
> void xe_gt_idle_disable_pg(struct xe_gt *gt);
> int xe_gt_idle_pg_print(struct xe_gt *gt, struct drm_printer *p);
>+u64 xe_gt_idle_residency(struct xe_gt_idle *gtidle);


this xe_gt_idle changes should be in a prep patch, and make unit
visible:

xe_gt_idle_residency_msec().

AFAICS it's a pre-existent problem, but now it's worse as you have 2
entrypoints:  there's no lock protecting gtidle updates. This means that
if you have perf running and something cat'ing the idle_residency_ms
file you are likely to have {prev,cur}_residency out of sync.

>
> #endif /* _XE_GT_IDLE_H_ */
>diff --git a/drivers/gpu/drm/xe/xe_pmu.c b/drivers/gpu/drm/xe/xe_pmu.c
>index 55668bd0178f..951c1b86aa88 100644
>--- a/drivers/gpu/drm/xe/xe_pmu.c
>+++ b/drivers/gpu/drm/xe/xe_pmu.c
>@@ -11,8 +11,11 @@
> #include "xe_device.h"
> #include "xe_force_wake.h"
> #include "xe_gt_clock.h"
>+#include "xe_gt_idle.h"
>+#include "xe_guc_pc.h"
> #include "xe_mmio.h"
> #include "xe_macros.h"
>+#include "xe_module.h"
> #include "xe_pm.h"
> #include "xe_pmu.h"
>
>@@ -46,8 +49,29 @@ static unsigned int xe_pmu_target_cpu = -1;
>  * To list a specific event for a GT at regular intervals-
>  * $ perf stat -e <event_name,xe_gt_id=> -I <interval>
>  *
>+ * For C6, following command will give GT residency per second-
>+ * $ perf stat -e xe_0000_00_02.0/c6-residency,xe_gt_id=0/ -I 1000
>+ *            time             counts unit events
>+ *     1.001183454               1001 ms   xe_0000_00_02.0/c6-residency,xe_gt_id=0/
>+ *     2.004434757               1002 ms   xe_0000_00_02.0/c6-residency,xe_gt_id=0/
>+ *     3.005854217               1000 ms   xe_0000_00_02.0/c6-residency,xe_gt_id=0/
>+ *
>+ * To verify this matches with sysfs values of c6, you can run following command-
>+ * $ for i in {1..10} ; do cat /sys/class/drm/card0/device/tile0/gt0/gtidle/idle_residency_ms;
>+ *   sleep 1; done
>+ *      2348877
>+ *      2349901
>+ *      2350917
>+ *      2352945
>+ *
>+ * Each value is roughly a 1000ms increment here as well. This is expected GT residency when idle.
>  */
>
>+static struct xe_pmu *event_to_pmu(struct perf_event *event)
>+{
>+	return container_of(event->pmu, struct xe_pmu, base);
>+}
>+
> static unsigned int config_gt_id(const u64 config)
> {
> 	return config >> __XE_PMU_GT_SHIFT;
>@@ -58,6 +82,35 @@ static u64 config_counter(const u64 config)
> 	return config & ~(~0ULL << __XE_PMU_GT_SHIFT);
> }
>
>+static unsigned int other_bit(const u64 config)
>+{
>+	unsigned int val;
>+
>+	switch (config_counter(config)) {
>+	case XE_PMU_C6_RESIDENCY:
>+		val = __XE_PMU_C6_RESIDENCY_ENABLED;
>+		break;
>+	default:
>+		/*
>+		 * Events that do not require sampling, or tracking state
>+		 * transitions between enabled and disabled can be ignored.
>+		 */
>+		return -1;
>+	}
>+
>+	return config_gt_id(config) * __XE_PMU_TRACKED_EVENT_COUNT + val;
>+}
>+
>+static unsigned int config_bit(const u64 config)
>+{
>+	return other_bit(config);
>+}
>+
>+static unsigned int event_bit(struct perf_event *event)
>+{
>+	return config_bit(event->attr.config);
>+}
>+
> static void xe_pmu_event_destroy(struct perf_event *event)
> {
> 	struct xe_device *xe =
>@@ -77,6 +130,10 @@ config_status(struct xe_device *xe, u64 config)
> 		return -ENOENT;
>
> 	switch (config_counter(config)) {
>+	case XE_PMU_C6_RESIDENCY:
>+		if (xe->info.skip_guc_pc)
>+			return -ENODEV;
>+		break;
> 	default:
> 		return -ENOENT;
> 	}
>@@ -125,6 +182,63 @@ static int xe_pmu_event_init(struct perf_event *event)
> 	return 0;
> }
>
>+static inline s64 ktime_since_raw(const ktime_t kt)
>+{
>+	return ktime_to_ms(ktime_sub(ktime_get_raw(), kt));
>+}
>+
>+static u64 read_sample(struct xe_pmu *pmu, unsigned int gt_id, int sample)
>+{
>+	return pmu->event_sample[gt_id][sample].cur;
>+}
>+
>+static void
>+store_sample(struct xe_pmu *pmu, unsigned int gt_id, int sample, u64 val)
>+{
>+	pmu->event_sample[gt_id][sample].cur = val;
>+}
>+
>+static u64 get_rc6(struct xe_gt *gt)
>+{
>+	struct xe_device *xe = gt_to_xe(gt);
>+	const unsigned int gt_id = gt->info.id;
>+	struct xe_pmu *pmu = &xe->pmu;
>+	bool device_awake;
>+	unsigned long flags;
>+	u64 val;
>+
>+	device_awake = xe_pm_runtime_get_if_active(xe);
>+	if (device_awake) {
>+		val = xe_gt_idle_residency(&gt->gtidle);
>+		xe_pm_runtime_put(xe);
>+	}
>+
>+	spin_lock_irqsave(&pmu->lock, flags);

another current huge pain from i915...  this can't be a spinlock_t
since the perf infra is holding a raw_spinlock_t when it calls
enable/read/etc.

See https://intel-gfx-ci.01.org/tree/drm-tip/shards-all.html?testfilter=perf

<4> [97.879451] =============================
<4> [97.879495] [ BUG: Invalid wait context ]
<4> [97.879538] 6.13.0-rc2-CI_DRM_15815-g6fc9ce9b9be4+ #1 Not tainted
<4> [97.879600] -----------------------------
<4> [97.879641] swapper/0/0 is trying to lock:
<4> [97.879684] ffff88812045b910 (&pmu->lock){....}-{3:3}, at: i915_pmu_enable+0x48/0x3a0 [i915]
<4> [97.880184] other info that might help us debug this:
<4> [97.880235] context-{5:5}
<4> [97.880264] 1 lock held by swapper/0/0:
<4> [97.880308]  #0: ffff88885f432038 (&cpuctx_lock){....}-{2:2}, at: __perf_install_in_context+0x3f/0x360
<4> [97.880411] stack backtrace:
<4> [97.880443] CPU: 0 UID: 0 PID: 0 Comm: swapper/0 Not tainted 6.13.0-rc2-CI_DRM_15815-g6fc9ce9b9be4+ #1
<4> [97.880535] Hardware name: Intel Corporation Meteor Lake Client Platform/MTL-P LP5x T3 RVP, BIOS MTLPFWI1.R00.3471.D91.2401310918 01/31/2024
<4> [97.880656] Call Trace:
<4> [97.880683]  <TASK>
<4> [97.880708]  dump_stack_lvl+0x91/0xf0
<4> [97.880752]  dump_stack+0x10/0x20
<4> [97.880789]  __lock_acquire+0x990/0x2820
<4> [97.880839]  lock_acquire+0xc9/0x300
<4> [97.880881]  ? i915_pmu_enable+0x48/0x3a0 [i915]
<4> [97.881355]  _raw_spin_lock_irqsave+0x49/0x80
<4> [97.881409]  ? i915_pmu_enable+0x48/0x3a0 [i915]
<4> [97.881723]  i915_pmu_enable+0x48/0x3a0 [i915]
<4> [97.882011]  i915_pmu_event_add+0x71/0x90 [i915]


I'm trying to fix that in i915, but it's not easy as we can't simply
convert to raw_spinlock_t :-/



>+
>+	if (device_awake) {
>+		store_sample(pmu, gt_id, __XE_SAMPLE_C6, val);
>+	} else {
>+		/*
>+		 * We think we are runtime suspended.
>+		 *
>+		 * Report the delta from when the device was suspended to now,
>+		 * on top of the last known real value, as the approximated C6
>+		 * counter value.
>+		 */
>+		val = ktime_since_raw(pmu->sleep_last[gt_id]);
>+		val += read_sample(pmu, gt_id, __XE_SAMPLE_C6);
>+	}
>+
>+	if (val < read_sample(pmu, gt_id, __XE_SAMPLE_C6_LAST_REPORTED))
>+		val = read_sample(pmu, gt_id, __XE_SAMPLE_C6_LAST_REPORTED);
>+	else
>+		store_sample(pmu, gt_id, __XE_SAMPLE_C6_LAST_REPORTED, val);
>+
>+	spin_unlock_irqrestore(&pmu->lock, flags);
>+
>+	return val;
>+}
>+
> static u64 __xe_pmu_event_read(struct perf_event *event)
> {
> 	struct xe_device *xe =
>@@ -135,6 +249,9 @@ static u64 __xe_pmu_event_read(struct perf_event *event)
> 	u64 val = 0;
>
> 	switch (config_counter(config)) {
>+	case XE_PMU_C6_RESIDENCY:
>+		val = get_rc6(gt);
>+		break;
> 	default:
> 		drm_warn(&gt->tile->xe->drm, "unknown pmu event\n");
> 	}
>@@ -165,6 +282,28 @@ static void xe_pmu_event_read(struct perf_event *event)
>
> static void xe_pmu_enable(struct perf_event *event)
> {
>+	struct xe_pmu *pmu = event_to_pmu(event);
>+	const unsigned int bit = event_bit(event);
>+	unsigned long flags;
>+
>+	if (bit == -1)
>+		goto update;
>+
>+	spin_lock_irqsave(&pmu->lock, flags);
>+
>+	/*
>+	 * Update the bitmask of enabled events and increment
>+	 * the event reference counter.
>+	 */
>+	BUILD_BUG_ON(ARRAY_SIZE(pmu->enable_count) != XE_PMU_MASK_BITS);
>+	XE_WARN_ON(bit >= ARRAY_SIZE(pmu->enable_count));
>+	XE_WARN_ON(pmu->enable_count[bit] == ~0);
>+
>+	pmu->enable |= BIT(bit);
>+	pmu->enable_count[bit]++;
>+
>+	spin_unlock_irqrestore(&pmu->lock, flags);
>+update:
> 	/*
> 	 * Store the current counter value so we can report the correct delta
> 	 * for all listeners. Even when the event was already enabled and has
>@@ -173,6 +312,31 @@ static void xe_pmu_enable(struct perf_event *event)
> 	local64_set(&event->hw.prev_count, __xe_pmu_event_read(event));
> }
>
>+static void xe_pmu_disable(struct perf_event *event)
>+{
>+	struct xe_device *xe =
>+		container_of(event->pmu, typeof(*xe), pmu.base);
>+	struct xe_pmu *pmu = &xe->pmu;
>+	const unsigned int bit = event_bit(event);
>+	unsigned long flags;
>+
>+	if (bit == -1)
>+		return;
>+
>+	spin_lock_irqsave(&pmu->lock, flags);
>+
>+	XE_WARN_ON(bit >= ARRAY_SIZE(pmu->enable_count));
>+	XE_WARN_ON(pmu->enable_count[bit] == 0);
>+	/*
>+	 * Decrement the reference count and clear the enabled
>+	 * bitmask when the last listener on an event goes away.
>+	 */
>+	if (--pmu->enable_count[bit] == 0)
>+		pmu->enable &= ~BIT(bit);
>+
>+	spin_unlock_irqrestore(&pmu->lock, flags);
>+}
>+
> static void xe_pmu_event_start(struct perf_event *event, int flags)
> {
> 	struct xe_device *xe =
>@@ -198,6 +362,8 @@ static void xe_pmu_event_stop(struct perf_event *event, int flags)
> 	if (flags & PERF_EF_UPDATE)
> 		xe_pmu_event_read(event);
>
>+	xe_pmu_disable(event);
>+
> out:
> 	event->hw.state = PERF_HES_STOPPED;
> }
>@@ -330,6 +496,7 @@ create_event_attributes(struct xe_pmu *pmu)
> 		const char *name;
> 		const char *unit;
> 	} events[] = {
>+		__event(0, "c6-residency", "ms"),
> 	};
>
> 	struct perf_pmu_events_attr *pmu_attr = NULL, *pmu_iter;
>@@ -511,6 +678,33 @@ static void xe_pmu_unregister_cpuhp_state(struct xe_pmu *pmu)
> 	cpuhp_state_remove_instance(cpuhp_state, &pmu->cpuhp.node);
> }
>
>+static void store_rc6_residency(struct xe_gt *gt)
>+{
>+	struct xe_device *xe = gt_to_xe(gt);
>+	struct xe_pmu *pmu = &xe->pmu;
>+
>+	store_sample(pmu, gt->info.id, __XE_SAMPLE_C6,
>+		     xe_gt_idle_residency(&gt->gtidle));
>+	pmu->sleep_last[gt->info.id] = ktime_get_raw();
>+}
>+
>+/**
>+ * xe_pmu_suspend() - Save residency count before suspend
>+ * @gt: GT object
>+ */
>+void xe_pmu_suspend(struct xe_gt *gt)
>+{
>+	struct xe_device *xe = gt_to_xe(gt);
>+	struct xe_pmu *pmu = &xe->pmu;
>+
>+	if (!pmu->base.event_init)
>+		return;
>+
>+	spin_lock_irq(&pmu->lock);
>+	store_rc6_residency(gt);
>+	spin_unlock_irq(&pmu->lock);
>+}
>+
> /**
>  * xe_pmu_unregister() - Remove/cleanup PMU registration
>  * @arg: Ptr to pmu
>@@ -536,6 +730,24 @@ void xe_pmu_unregister(void *arg)
> 	free_event_attributes(pmu);
> }
>
>+static void init_rc6(struct xe_pmu *pmu)
>+{
>+	struct xe_device *xe = container_of(pmu, typeof(*xe), pmu);
>+	struct xe_gt *gt;
>+	unsigned int j;
>+
>+	for_each_gt(gt, xe, j) {
>+		xe_pm_runtime_get(xe);
>+		u64 val = xe_gt_idle_residency(&gt->gtidle);
>+
>+		store_sample(pmu, j, __XE_SAMPLE_C6, val);
>+		store_sample(pmu, j, __XE_SAMPLE_C6_LAST_REPORTED,
>+			     val);
>+		pmu->sleep_last[j] = ktime_get_raw();
>+		xe_pm_runtime_put(xe);
>+	}
>+}
>+
> /**
>  * xe_pmu_register() - Define basic PMU properties for Xe and add event callbacks.
>  * @pmu: the PMU object
>@@ -575,6 +787,8 @@ void xe_pmu_register(struct xe_pmu *pmu)
> 	if (!pmu->events_attr_group.attrs)
> 		goto err_name;
>
>+	init_rc6(pmu);
>+
> 	pmu->base.attr_groups = kmemdup(attr_groups, sizeof(attr_groups),
> 					GFP_KERNEL);
> 	if (!pmu->base.attr_groups)
>diff --git a/drivers/gpu/drm/xe/xe_pmu.h b/drivers/gpu/drm/xe/xe_pmu.h
>index d07e5dfdfec0..17f5a8d7d45c 100644
>--- a/drivers/gpu/drm/xe/xe_pmu.h
>+++ b/drivers/gpu/drm/xe/xe_pmu.h
>@@ -15,11 +15,13 @@ int xe_pmu_init(void);
> void xe_pmu_exit(void);
> void xe_pmu_register(struct xe_pmu *pmu);
> void xe_pmu_unregister(void *arg);
>+void xe_pmu_suspend(struct xe_gt *gt);
> #else
> static inline int xe_pmu_init(void) { return 0; }
> static inline void xe_pmu_exit(void) {}
> static inline void xe_pmu_register(struct xe_pmu *pmu) {}
> static inline void xe_pmu_unregister(void *arg) {}
>+static inline void xe_pmu_suspend(struct xe_gt *gt) {}
> #endif
>
> #endif
>diff --git a/drivers/gpu/drm/xe/xe_pmu_types.h b/drivers/gpu/drm/xe/xe_pmu_types.h
>index 920518967c84..b150850ae57d 100644
>--- a/drivers/gpu/drm/xe/xe_pmu_types.h
>+++ b/drivers/gpu/drm/xe/xe_pmu_types.h
>@@ -10,6 +10,8 @@
> #include <linux/spinlock_types.h>
>
> enum {
>+	__XE_SAMPLE_C6,
>+	__XE_SAMPLE_C6_LAST_REPORTED,
> 	__XE_NUM_PMU_SAMPLERS
> };
>
>@@ -25,6 +27,26 @@ enum {
>
> #define __XE_PMU_PM(x) ___XE_PMU_PM(0, x)
>
>+#define XE_PMU_C6_RESIDENCY                    __XE_PMU_PM(0)
>+#define __XE_PMU_C6_RESIDENCY(gt)              ___XE_PMU_PM(gt, 0)
>+
>+/*
>+ * Non-engine events that we need to track enabled-disabled transition and
>+ * current state.
>+ */
>+enum xe_pmu_tracked_events {
>+	__XE_PMU_C6_RESIDENCY_ENABLED,
>+	__XE_PMU_TRACKED_EVENT_COUNT, /* count marker */
>+};
>+
>+/* Global PMU mask to track enabled events */
>+#define XE_PMU_MASK_BITS \
>+	(XE_PMU_MAX_GT * __XE_PMU_TRACKED_EVENT_COUNT)
>+
>+struct xe_pmu_sample {
>+	u64 cur;
>+};
>+
> struct xe_pmu {
> 	/**
> 	 * @cpuhp: Struct used for CPU hotplug handling.
>@@ -67,6 +89,41 @@ struct xe_pmu {
> 	 * @pmu_attr: Memory block holding device attributes.
> 	 */
> 	void *pmu_attr;
>+
>+	/**
>+	 * @enable: Bitmask of specific enabled events.
>+	 *
>+	 * For some events we need to track their state and do some internal
>+	 * house keeping.
>+	 *
>+	 * Each engine event sampler type and event listed in enum
>+	 * i915_pmu_tracked_events gets a bit in this field.

i915?


apparently this doesn't do anything here, it's only incrementing and
decrementing a counter without doing anything. What am I missing?


Lucas De Marchi

>+	 *
>+	 * Low bits are engine samplers and other events continue from there.
>+	 */
>+	u32 enable;
>+
>+	/**
>+	 * @enable_count: Reference counter for enabled events.
>+	 *
>+	 * Array indices are mapped in the same way as bits in the @enable field
>+	 * and they are used to control sampling on/off when multiple clients
>+	 * are using the PMU API.
>+	 */
>+	unsigned int enable_count[XE_PMU_MASK_BITS];
>+	/**
>+	 * @sample: Current and previous (raw) counters for sampling events.
>+	 *
>+	 * These counters are updated from the i915 PMU sampling timer.
>+	 *
>+	 * Only global counters are held here, while the per-engine ones are in
>+	 * struct intel_engine_cs.
>+	 */
>+	struct xe_pmu_sample event_sample[XE_PMU_MAX_GT][__XE_NUM_PMU_SAMPLERS];
>+	/**
>+	 * @sleep_last: Last time GT parked for C6 estimation.
>+	 */
>+	ktime_t sleep_last[XE_PMU_MAX_GT];
> };
>
> #endif
>-- 
>2.38.1
>


More information about the Intel-xe mailing list