[PATCH v2 4/5] drm/xe/reg_sr: Stop setting all whitelist slots

[Matt Roper]

On Mon, Dec 09, 2024 at 03:27:38PM -0800, Lucas De Marchi wrote:
> Currently xe_reg_sr_apply_whitelist() sets the unused values to a known
> used value for no good reason: it could just leave it with the HW
> default. The behavior is slightly different if there are no whitelist
> registers for the engine as the function returns early. This is not
> needed, so just drop the addition writes for the unused slots.
> 
> Later this will allow to reduce the amount of registers passed to GuC
> for save/restore.
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>

Reviewed-by: Matt Roper <matthew.d.roper at intel.com>

> ---
>  drivers/gpu/drm/xe/xe_reg_sr.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_reg_sr.c b/drivers/gpu/drm/xe/xe_reg_sr.c
> index 080229e0fc15a..0a5c0e62d6e88 100644
> --- a/drivers/gpu/drm/xe/xe_reg_sr.c
> +++ b/drivers/gpu/drm/xe/xe_reg_sr.c
> @@ -227,13 +227,6 @@ void xe_reg_sr_apply_whitelist(struct xe_hw_engine *hwe)
>  		slot++;
>  	}
>  
> -	/* And clear the rest just in case of garbage */
> -	for (; slot < RING_MAX_NONPRIV_SLOTS; slot++) {
> -		u32 addr = RING_NOPID(mmio_base).addr;
> -
> -		xe_mmio_write32(&gt->mmio, RING_FORCE_TO_NONPRIV(mmio_base, slot), addr);
> -	}
> -
>  	xe_force_wake_put(gt_to_fw(gt), fw_ref);
>  
>  	return;
> -- 
> 2.47.0
> 

-- 
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation