✗ CI.checkpatch: warning for drm/xe/client: Better correlate exec_queue and GT timestamps
Patchwork
patchwork at emeril.freedesktop.org
Thu Dec 12 19:25:24 UTC 2024
== Series Details ==
Series: drm/xe/client: Better correlate exec_queue and GT timestamps
URL : https://patchwork.freedesktop.org/series/142501/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
30ab6715fc09baee6cc14cb3c89ad8858688d474
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit b24de0f67f9dd0b27be0faf6a723e410e5458b37
Author: Lucas De Marchi <lucas.demarchi at intel.com>
Date: Thu Dec 12 09:34:32 2024 -0800
drm/xe/client: Better correlate exec_queue and GT timestamps
This partially reverts commit fe4f5d4b6616 ("drm/xe: Clean up VM / exec
queue file lock usage."). While it's desired to have the mutex to
protect only the reference to the exec queue, getting and dropping each
mutex and then later getting the GPU timestamp, doesn't produce a
correct result: it introduces multiple opportunities for the task to be
scheduled out and thus wrecking havoc the deltas reported to userspace.
Also, to better correlate the timestamp from the exec queues with the
GPU, disable preemption so they can be updated without allowing the task
to be scheduled out. We leave interrupts enabled as that shouldn't be
enough disturbance for the deltas to matter to userspace.
Test scenario:
* IGT'S `xe_drm_fdinfo --r --r utilization-single-full-load`
* Platform: LNL, where CI occasionally reports failures
* `stress -c $(nproc)` running in parallel to disturb the
system
This brings a first failure from "after ~150 executions" to "never
occurs after 1000 attempts".
Cc: stable at vger.kernel.org # v6.11+
Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/3512
Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
+ /mt/dim checkpatch 1833817dea7ab2961cc662bfc451bc232c5d24cc drm-intel
b24de0f67f9d drm/xe/client: Better correlate exec_queue and GT timestamps
-:54: WARNING:MISSING_FIXES_TAG: The commit message has 'stable@', perhaps it also needs a 'Fixes:' tag?
total: 0 errors, 1 warnings, 0 checks, 18 lines checked
More information about the Intel-xe
mailing list