[PATCH 10/11] drm/xe: Split init of xe_gt_init_hwconfig to xe_gt_init and *_early
Lucas De Marchi
lucas.demarchi at intel.com
Fri Dec 13 00:36:45 UTC 2024
On Wed, Dec 11, 2024 at 07:52:49PM +0100, Maarten Lankhorst wrote:
>Hey,
>
>Den 2024-12-10 kl. 16:25, skrev Lucas De Marchi:
>>On Tue, Dec 10, 2024 at 09:31:10AM +0100, Maarten Lankhorst wrote:
>>>static void dump_pat_on_error(struct xe_gt *gt)
>>>@@ -419,6 +438,18 @@ static int gt_fw_domain_init(struct xe_gt *gt)
>>> goto err_hw_fence_irq;
>>> }
>>>
>>>+ err = xe_uc_init(>->uc);
>>
>>what does this have to do with gt_fw_domain_init()? We should look at
>>removing unrelated stuff from this function rather than stashing more.
>>
>>Lucas De Marchi
>
>It just needs to be called with FW and during that point of init, can
>perhaps create separate functions all called with fw instead?
splitting that up seems ok to me.
Lucas De Marchi
>
>Cheers,
>Maarten
>
More information about the Intel-xe
mailing list