[PATCH] Revert "drm/xe/devcoredump: Add ASCII85 dump helper function"

Lucas De Marchi lucas.demarchi at intel.com
Fri Dec 13 14:38:12 UTC 2024


On Fri, Dec 13, 2024 at 09:12:52AM -0500, Rodrigo Vivi wrote:
>We do not break userspace.
>
>This reverts commit ec1455ce7e35a31289d2dbc1070b980538698921.

But we have users calling this function.... the revert is not so simple.
I think we need to revert the functionality rather than reverting all
the patches, otherwise it will cause a lot of headaches.

I propose we go with:

a) drop the \n that broke mesa and merge that with cc stable.

b) move back the entry to the previous section that broke mesa and cc
    stable.

    José, would it be ok to merge a patch in mesa and port that
    to mesa stable that simply looks at 2 possible sections? Or even
    drop the section checks... ?

c) settle on one of the possible solutions for \n that were presented in
    this discussion.  I think the sanest one is that a space in the end of a
    line printing ascii85 would signify a continuation marker.  But merging
    (a) means we have time to discuss and adjust if needed.

After the dust settles we may think of a better way to evolve the
devcoredump format so it doesn't cause breakages in future updates.

Lucas De Marchi


More information about the Intel-xe mailing list