✗ CI.checkpatch: warning for series starting with [1/7] drm/xe: use backup object for pinned save/restore

Patchwork patchwork at emeril.freedesktop.org
Mon Dec 16 16:39:18 UTC 2024


== Series Details ==

Series: series starting with [1/7] drm/xe: use backup object for pinned save/restore
URL   : https://patchwork.freedesktop.org/series/142664/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
30ab6715fc09baee6cc14cb3c89ad8858688d474
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 8e10b2435532a89cebfeabfbf57df314ea34e5bf
Author: Matthew Auld <matthew.auld at intel.com>
Date:   Mon Dec 16 16:29:48 2024 +0000

    drm/xe/sriov: support non-contig VRAM provisioning
    
    Currently we can run into issues with provisioning VRAM region, due to
    requiring contig VRAM BO underneath. We sometimes see that allocation
    (multiple GB) can fail even when there is enough free space.  We don't
    need CPU access to the buffer in the first place, so can forgo pin_map
    and therefore also the contig requirement. Keep the same behavior with
    save and restore during suspend/resume (which can now be done with
    blitter).  We also need the VRAM to occupy the same pages so we don't
    need to re-program the LMTT, so should still remain pinned (also we
    don't want something to try evict it). With that covert over to plain
    pinned kernel object.
    
    Signed-off-by: Matthew Auld <matthew.auld at intel.com>
    Cc: Satyanarayana K V P <satyanarayana.k.v.p at intel.com>
    Cc: Thomas Hellström <thomas.hellstrom at linux.intel.com>
    Cc: Matthew Brost <matthew.brost at intel.com>
+ /mt/dim checkpatch 49cc582754c205bbe43d4ef2b1fd3894bee1f3bd drm-intel
0d668b8a37c9 drm/xe: use backup object for pinned save/restore
-:108: CHECK:BRACES: Unbalanced braces around else statement
#108: FILE: drivers/gpu/drm/xe/xe_bo.c:792:
+	} else

-:195: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#195: FILE: drivers/gpu/drm/xe/xe_bo.c:872:
+	backup = xe_bo_create_locked(xe, NULL, NULL, bo->size, ttm_bo_type_kernel,
+			      XE_BO_FLAG_SYSTEM | XE_BO_FLAG_NEEDS_CPU_ACCESS | XE_BO_FLAG_PINNED);

total: 0 errors, 0 warnings, 2 checks, 380 lines checked
40a0d925c7b1 drm/xe: split pinned save/restore into phases
d732ffa49657 drm/xe: Add XE_BO_FLAG_PINNED_NORESTORE
154851352225 drm/xe: add XE_BO_FLAG_PINNED_EARLY_RESTORE
769bbe53c8f4 drm/xe: unconditionally apply PINNED for pin_map()
498d942f40bc drm/xe: allow non-contig VRAM kernel BO
8e10b2435532 drm/xe/sriov: support non-contig VRAM provisioning




More information about the Intel-xe mailing list