✗ CI.checkpatch: warning for Fixes for MI_REPORT_PERF_COUNT (rev2)
Patchwork
patchwork at emeril.freedesktop.org
Tue Dec 17 02:30:54 UTC 2024
== Series Details ==
Series: Fixes for MI_REPORT_PERF_COUNT (rev2)
URL : https://patchwork.freedesktop.org/series/141811/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
30ab6715fc09baee6cc14cb3c89ad8858688d474
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 4fc1690fa74aadb3421baf53dd20471692b9f138
Author: Umesh Nerlige Ramappa <umesh.nerlige.ramappa at intel.com>
Date: Mon Dec 16 16:58:18 2024 -0800
xe/oa: Use MI_LOAD_REGISTER_IMMEDIATE to enable OAR/OAC
To enable OAR/OAC, a bit in RING_CONTEXT_CONTROL needs to be set.
Setting this bit cause the context image size to change and if not done
correct, can cause undesired hangs.
Current code uses a separate exec_queue to modify this bit and is
error-prone. As per HW recommendation, submit MI_LOAD_REGISTER_IMM to
the target hardware context to modify the relevant bit.
In v2 version, an attempt to submit everything to the user-queue was
made, but it failed the unprivileged-single-ctx-counters test. It
appears that the OACTXCONTROL must be modified from a remote context.
In summary,
- the OACTXCONTROL is always modified from the k_exec_q
- the LRI registers are always modified from the user-queue
- emit_oa_config picks user-queue if available, else it uses k_exec_q.
v2:
(Matt)
- set job->ggtt to true if create job is successful
- unlock vm on job error
(Ashutosh)
- don't wait on job submission
- use kernel exec queue where possible
Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa at intel.com>
Acked-by: Matthew Brost <matthew.brost at intel.com>
+ /mt/dim checkpatch e7c9466eaad2e3e60e6dbd2725a648b58c717fb0 drm-intel
8689a8176f92 xe: Allow a GGTT mapped batch to be submitted to user exec queue
4fc1690fa74a xe/oa: Use MI_LOAD_REGISTER_IMMEDIATE to enable OAR/OAC
-:204: ERROR:CODE_INDENT: code indent should use tabs where possible
#204: FILE: drivers/gpu/drm/xe/xe_oa.c:843:
+ ^I};$
-:204: WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#204: FILE: drivers/gpu/drm/xe/xe_oa.c:843:
+ ^I};$
-:204: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#204: FILE: drivers/gpu/drm/xe/xe_oa.c:843:
+ ^I};$
total: 1 errors, 2 warnings, 0 checks, 183 lines checked
More information about the Intel-xe
mailing list