[PATCH 0/2] Introduce fault injection for guc CTB & mmio send/recv.

[Matthew Brost]

On Thu, Dec 19, 2024 at 09:01:57AM -0700, Cavitt, Jonathan wrote:
> It might be a bit difficult to get approval for this series if there isn't an associated IGT
> test ready to exercise the added error injection.  Namely, I think the functions
> xe_guc_mmio_send_recv and xe_guc_ct_send_recv need to be added to the array
> probe_fail_functions in xe_fault_injection.c in IGT before this can land.
> 
> Once the tests for IGT are submitted for review, you'll want to use Test-with to
> exercise the new IGT functionality: https://intel-gfx-ci.01.org/test-with.html
> 
> This isn't a NACK, by the way.  I just figured I should give a heads up.
> -Jonathan Cavitt
> 

Agree with Jonathan, we should have an IGT which uses these injection points.

Matt

> -----Original Message-----
> From: Intel-xe <intel-xe-bounces at lists.freedesktop.org> On Behalf Of Satyanarayana K V P
> Sent: Wednesday, December 18, 2024 10:50 PM
> To: intel-xe at lists.freedesktop.org
> Cc: K V P, Satyanarayana <satyanarayana.k.v.p at intel.com>
> Subject: [PATCH 0/2] Introduce fault injection for guc CTB & mmio send/recv.
> > 
> > Introduce fault injection for guc CTB & mmio send/recv
> > 
> > Enable below Kconfig options.
> > CONFIG_KUNIT=m
> > CONFIG_KUNIT_DEBUGFS=y
> > CONFIG_FAIL_FUNCTION=y
> > CONFIG_FAULT_INJECTION=y
> > CONFIG_FAULT_INJECTION_DEBUG_FS=y
> > CONFIG_FUNCTION_ERROR_INJECTION=y
> > 
> > Fault can be injected with below steps.
> > FAILTYPE=fail_function
> > FAILFUNC=xe_guc_ct_send_recv
> > 
> > echo > /sys/kernel/debug/$FAILTYPE/inject
> > echo $FAILFUNC > /sys/kernel/debug/$FAILTYPE/inject
> > printf %#x -19 > /sys/kernel/debug/$FAILTYPE/$FAILFUNC/retval
> > 
> > echo N > /sys/kernel/debug/$FAILTYPE/task-filter
> > echo 10 > /sys/kernel/debug/$FAILTYPE/probability
> > echo 0 > /sys/kernel/debug/$FAILTYPE/interval
> > echo -1 > /sys/kernel/debug/$FAILTYPE/times
> > echo 0 > /sys/kernel/debug/$FAILTYPE/space
> > echo 1 > /sys/kernel/debug/$FAILTYPE/verbose
> > 
> > 
> > Satyanarayana K V P (2):
> >   drm/xe: Introduce fault injection for guc mmio send/recv.
> >   drm/xe: Introduce fault injection for guc CTB send/recv
> > 
> >  drivers/gpu/drm/xe/xe_guc.c    | 1 +
> >  drivers/gpu/drm/xe/xe_guc_ct.c | 1 +
> >  2 files changed, 2 insertions(+)
> > 
> > -- 
> > 2.35.3
> > 
> >