✗ CI.checkpatch: warning for drm/i915/cmtg: Disable the CMTG (rev3)

Patchwork patchwork at emeril.freedesktop.org
Tue Dec 24 17:01:53 UTC 2024


== Series Details ==

Series: drm/i915/cmtg: Disable the CMTG (rev3)
URL   : https://patchwork.freedesktop.org/series/142946/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
30ab6715fc09baee6cc14cb3c89ad8858688d474
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit d090b95c28ef1959443ce25129db689c40a16382
Author: Gustavo Sousa <gustavo.sousa at intel.com>
Date:   Tue Dec 24 13:53:45 2024 -0300

    drm/i915/cmtg: Disable the CMTG
    
    The CMTG is a timing generator that runs in parallel with transcoders
    timing generators and can be used as a reference for synchronization.
    
    On PTL (display Xe3_LPD), we have observed that we are inheriting from
    GOP a display configuration with the CMTG enabled. Because our driver
    doesn't currently implement any CMTG sequences, the CMTG ends up still
    enabled after our driver takes over.
    
    We need to make sure that the CMTG is not enabled if we are not going to
    use it. For that, let's add a partial implementation in our driver that
    only cares about disabling the CMTG if it was found enabled during
    initial hardware readout. In the future, we can also implement sequences
    for enabling CMTG if that becomes a needed feature.
    
    For completeness, we do not only cover Xe3_LPD but also all previous
    display IPs that provide the CMTG.
    
    v2:
     - DG2 does not have the CMTG. Update HAS_CMTG() accordingly.
     - Update logic to force disabling of CMTG only for initial commit.
    v3:
     - Add missing changes for v2 that were staged but not committed.
    
    Signed-off-by: Gustavo Sousa <gustavo.sousa at intel.com>
+ /mt/dim checkpatch 08bd590935a5258ffd79355c59adffd72fb2c642 drm-intel
d090b95c28ef drm/i915/cmtg: Disable the CMTG
-:44: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#44: 
new file mode 100644

-:497: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__display' - possible side-effects?
#497: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:148:
+#define HAS_CMTG(__display)		(!(__display)->platform.dg2 && DISPLAY_VER(__display) >= 13)

total: 0 errors, 1 warnings, 1 checks, 483 lines checked




More information about the Intel-xe mailing list