[PATCH] drm/xe/Kconfig: Select FB_CORE with FB_IOMEM_HELPERS

[Lucas De Marchi]

On Thu, Feb 01, 2024 at 08:47:54AM +0100, Thomas Hellström wrote:
>FB_IOMEM_HELPERS depends on FB_CORE.
>
>Fixes: 44e694958b95 ("drm/xe/display: Implement display support")

Closes: https://lore.kernel.org/intel-xe/e1797d02-d947-4b35-af55-9ff1d72125aa@infradead.org/

?

>Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
>Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
>Cc: Lucas De Marchi <lucas.demarchi at intel.com>
>Signed-off-by: Thomas Hellström <thomas.hellstrom at linux.intel.com>
>---
> drivers/gpu/drm/xe/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig
>index e36ae1f0d885..e0bcf835e0a5 100644
>--- a/drivers/gpu/drm/xe/Kconfig
>+++ b/drivers/gpu/drm/xe/Kconfig
>@@ -48,6 +48,7 @@ config DRM_XE
> config DRM_XE_DISPLAY
> 	bool "Enable display support"
> 	depends on DRM_XE && DRM_XE=m
>+	select FB_CORE
> 	select FB_IOMEM_HELPERS

shouldn't we be doing it like these other drivers?

	drivers/gpu/drm/armada/Kconfig
	drivers/gpu/drm/gma500/Kconfig
	drivers/gpu/drm/i915/Kconfig

i.e.:

	select FB_IOMEM_HELPERS if DRM_FBDEV_EMULATION

and then the corresponding changes in the source code to account for
lack thereof?

Lucas De Marchi